Add test for setting __factory__ attribute. Fix missing getter/setter for __factory__ in the cext.

ionelmc · ionelmc · commit a68627c7aaff · 2015-03-10T16:22:39.000+02:00
diff --git a/src/lazy_object_proxy/cext.c b/src/lazy_object_proxy/cext.c
@@ -1026,6 +1026,28 @@ static int Proxy_set_wrapped(ProxyObject *self,
 
 /* ------------------------------------------------------------------------- */
 
+static PyObject *Proxy_get_factory(
+        ProxyObject *self)
+{
+    Py_INCREF(self->factory);
+    return self->factory;
+}
+
+/* ------------------------------------------------------------------------- */
+
+static int Proxy_set_factory(ProxyObject *self,
+        PyObject *value)
+{
+    if (value) Py_INCREF(value);
+    Py_DECREF(self->factory);
+
+    self->factory = value;
+
+    return 0;
+}
+
+/* ------------------------------------------------------------------------- */
+
 static PyObject *Proxy_getattro(
         ProxyObject *self, PyObject *name)
 {
@@ -1253,6 +1275,8 @@ static PyGetSetDef Proxy_getset[] = {
                             (setter)Proxy_set_annotations, 0 },
     { "__wrapped__",        (getter)Proxy_get_wrapped,
                             (setter)Proxy_set_wrapped, 0 },
+    { "__factory__",        (getter)Proxy_get_factory,
+                            (setter)Proxy_set_factory, 0 },
     { NULL },
 };
 
diff --git a/tests/test_lazy_object_proxy.py b/tests/test_lazy_object_proxy.py
@@ -1607,6 +1607,18 @@ def foo():
     assert proxy.__factory__ is foo
 
 
+def test_patching_the_factory(lazy_object_proxy):
+    def foo():
+        raise AttributeError("boom!")
+    proxy = lazy_object_proxy.Proxy(foo)
+    pytest.raises(AttributeError, lambda: proxy.__wrapped__)
+    assert proxy.__factory__ is foo
+
+    proxy.__factory__ = lambda: foo
+    pytest.raises(AttributeError, proxy)
+    assert proxy.__wrapped__ is foo
+
+
 def test_new(lazy_object_proxy):
     a = lazy_object_proxy.Proxy.__new__(lazy_object_proxy.Proxy)
     b = lazy_object_proxy.Proxy.__new__(lazy_object_proxy.Proxy)
