Add 'ViewSet.detail' initkwarg

Ryan P Kilby · Ryan P Kilby · commit 046bf8a6763c · 2017-12-22T03:51:37.000-05:00
diff --git a/rest_framework/routers.py b/rest_framework/routers.py
@@ -284,6 +284,7 @@ def get_urls(self):
                 initkwargs = route.initkwargs.copy()
                 initkwargs.update({
                     'basename': basename,
+                    'detail': route.detail,
                 })
 
                 view = viewset.as_view(mapping, **initkwargs)
diff --git a/rest_framework/viewsets.py b/rest_framework/viewsets.py
@@ -56,6 +56,9 @@ def as_view(cls, actions=None, **initkwargs):
         # eg. 'List' or 'Instance'.
         cls.suffix = None
 
+        # The detail initkwarg is reserved for introspecting the viewset type.
+        cls.detail = None
+
         # Setting a basename allows a view to reverse its action urls. This
         # value is provided by the router through the initkwargs.
         cls.basename = None
diff --git a/tests/test_routers.py b/tests/test_routers.py
@@ -446,6 +446,12 @@ def test_suffix(self):
 
         assert initkwargs['suffix'] == 'List'
 
+    def test_detail(self):
+        match = resolve('/example/notes/')
+        initkwargs = match.func.initkwargs
+
+        assert not initkwargs['detail']
+
     def test_basename(self):
         match = resolve('/example/notes/')
         initkwargs = match.func.initkwargs
