Clarify pagination system check (#5524)

carltongibson · web-flow · commit 1c9ad52cb610 · 2017-10-23T12:31:59.000+02:00
* Add `id` to allow silencing. * Expand `hint` to clarify. Ref #5170 Closes #5523
diff --git a/rest_framework/checks.py b/rest_framework/checks.py
@@ -12,7 +12,10 @@ def pagination_system_check(app_configs, **kwargs):
                 "You have specified a default PAGE_SIZE pagination rest_framework setting,"
                 "without specifying also a DEFAULT_PAGINATION_CLASS.",
                 hint="The default for DEFAULT_PAGINATION_CLASS is None. "
-                     "In previous versions this was PageNumberPagination",
+                     "In previous versions this was PageNumberPagination. "
+                     "If you wish to define PAGE_SIZE globally whilst defining "
+                     "pagination_class on a per-view basis you may silence this check.",
+                id="rest_framework.W001"
             )
         )
     return errors

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,10 @@ def pagination_system_check(app_configs, **kwargs):`
`12`	`12`	`"You have specified a default PAGE_SIZE pagination rest_framework setting,"`
`13`	`13`	`"without specifying also a DEFAULT_PAGINATION_CLASS.",`
`14`	`14`	`hint="The default for DEFAULT_PAGINATION_CLASS is None. "`
`15`		`- "In previous versions this was PageNumberPagination",`
	`15`	`+ "In previous versions this was PageNumberPagination. "`
	`16`	`+ "If you wish to define PAGE_SIZE globally whilst defining "`
	`17`	`+ "pagination_class on a per-view basis you may silence this check.",`
	`18`	`+ id="rest_framework.W001"`
`16`	`19`	`)`
`17`	`20`	`)`
`18`	`21`	`return errors`