Skip to content

Commit 378d6a1

Browse files
committed
Allow HTML to render when no filter_class is defined.
Previously it required a filter_class, or else it would error when calling `cls()`. This now sets the `filter` context to `None` if one does not exist. Fixes #3559
1 parent b8c9c80 commit 378d6a1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

rest_framework/filters.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,10 @@ def filter_queryset(self, request, queryset, view):
118118

119119
def to_html(self, request, queryset, view):
120120
cls = self.get_filter_class(view, queryset)
121-
filter_instance = cls(request.query_params, queryset=queryset)
121+
if cls:
122+
filter_instance = cls(request.query_params, queryset=queryset)
123+
else:
124+
filter_instance = None
122125
context = Context({
123126
'filter': filter_instance
124127
})

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy