Test that meta fields cannot be declared as None

Ryan P Kilby · Ryan P Kilby · commit 478fe0a394fa · 2017-01-03T14:13:19.000-05:00
diff --git a/tests/test_serializer.py b/tests/test_serializer.py
@@ -7,6 +7,8 @@
 
 import pytest
 
+from django.db import models
+
 from rest_framework import fields, relations, serializers
 from rest_framework.compat import unicode_repr
 from rest_framework.fields import Field
@@ -430,3 +432,25 @@ class Grandchild(Child):
         assert len(Parent._declared_fields) == 2
         assert len(Child._declared_fields) == 1
         assert len(Grandchild._declared_fields) == 1
+
+    def test_meta_field_disabling(self):
+        # Declaratively setting a field on a child class will *not* prevent
+        # the ModelSerializer from generating a default field.
+        class MyModel(models.Model):
+            f1 = models.CharField(max_length=10)
+            f2 = models.CharField(max_length=10)
+
+        class Parent(serializers.ModelSerializer):
+            class Meta:
+                model = MyModel
+                fields = ['f1', 'f2']
+
+        class Child(Parent):
+            f1 = None
+
+        class Grandchild(Child):
+            pass
+
+        assert len(Parent().get_fields()) == 2
+        assert len(Child().get_fields()) == 2
+        assert len(Grandchild().get_fields()) == 2
