Fix SearchFilter renders field with invalid value (#9023)

drewg3r · Andrii Tarasenko · web-flow · commit 4f7e9ed3bbb0 · 2023-07-02T13:57:20.000+06:00
Co-authored-by: Andrii Tarasenko &lt;andrii.tarasenko@py-t.com&gt;
diff --git a/rest_framework/filters.py b/rest_framework/filters.py
@@ -139,11 +139,9 @@ def to_html(self, request, queryset, view):
         if not getattr(view, 'search_fields', None):
             return ''
 
-        term = self.get_search_terms(request)
-        term = term[0] if term else ''
         context = {
             'param': self.search_param,
-            'term': term
+            'term': request.query_params.get(self.search_param, ''),
         }
         template = loader.get_template(self.template)
         return template.render(context)
diff --git a/tests/test_filters.py b/tests/test_filters.py
@@ -225,6 +225,23 @@ def as_sql(self, compiler, connection):
                 {'id': 2, 'title': 'zz', 'text': 'bcd'},
             ]
 
+    def test_search_field_with_multiple_words(self):
+        class SearchListView(generics.ListAPIView):
+            queryset = SearchFilterModel.objects.all()
+            serializer_class = SearchFilterSerializer
+            filter_backends = (filters.SearchFilter,)
+            search_fields = ('title', 'text')
+
+        search_query = 'foo bar,baz'
+        view = SearchListView()
+        request = factory.get('/', {'search': search_query})
+        request = view.initialize_request(request)
+
+        rendered_search_field = filters.SearchFilter().to_html(
+            request=request, queryset=view.queryset, view=view
+        )
+        assert search_query in rendered_search_field
+
 
 class AttributeModel(models.Model):
     label = models.CharField(max_length=32)
