tests: fix skipping of tests without coreapi/coreschema

blueyed · blueyed · commit 518ab6431ff7 · 2018-06-21T16:36:10.000+02:00
diff --git a/tests/test_encoders.py b/tests/test_encoders.py
@@ -76,6 +76,7 @@ def test_encode_uuid(self):
         unique_id = uuid4()
         assert self.encoder.default(unique_id) == str(unique_id)
 
+    @pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
     def test_encode_coreapi_raises_error(self):
         """
         Tests encoding a coreapi objects raises proper error
diff --git a/tests/test_filters.py b/tests/test_filters.py
@@ -10,6 +10,7 @@
 from django.utils.six.moves import reload_module
 
 from rest_framework import filters, generics, serializers
+from rest_framework.compat import coreschema
 from rest_framework.test import APIRequestFactory
 
 factory = APIRequestFactory()
@@ -28,6 +29,7 @@ def test_filter_queryset_raises_error(self):
         with pytest.raises(NotImplementedError):
             self.filter_backend.filter_queryset(None, None, None)
 
+    @pytest.mark.skipif(not coreschema, reason='coreschema is not installed')
     def test_get_schema_fields_checks_for_coreapi(self):
         filters.coreapi = None
         with pytest.raises(AssertionError):
diff --git a/tests/test_renderers.py b/tests/test_renderers.py
@@ -709,6 +709,7 @@ def get(self, request):
         self.assertContains(response, '<tr><th>Iteritems</th><td>a string</td></tr>', html=True)
 
 
+@pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
 class TestDocumentationRenderer(TestCase):
 
     def test_document_with_link_named_data(self):
@@ -738,6 +739,7 @@ def test_document_with_link_named_data(self):
         assert '<h1>Data Endpoint API</h1>' in html
 
 
+@pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
 class TestSchemaJSRenderer(TestCase):
 
     def test_schemajs_output(self):
diff --git a/tests/test_schemas.py b/tests/test_schemas.py
@@ -663,6 +663,7 @@ def test_get_link_requires_instance(self):
         with pytest.raises(AssertionError):
             descriptor.get_link(None, None, None)  # ???: Do the dummy arguments require a tighter assert?
 
+    @pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
     def test_update_fields(self):
         """
         That updating fields by-name helper is correct
@@ -698,6 +699,7 @@ def test_update_fields(self):
         assert len(fields) == 1
         assert fields[0].required is False
 
+    @pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
     def test_get_manual_fields(self):
         """That get_manual_fields is applied during get_link"""
 
@@ -718,6 +720,7 @@ class CustomView(APIView):
         assert len(fields) == 2
         assert "my_extra_field" in [f.name for f in fields]
 
+    @pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
     def test_view_with_manual_schema(self):
 
         path = '/example'
@@ -764,6 +767,7 @@ class CustomView(APIView):
         link = view.schema.get_link(path, method, base_url)
         assert link == expected
 
+    @unittest.skipUnless(coreschema, 'coreschema is not installed')
     def test_field_to_schema(self):
         label = 'Test label'
         help_text = 'This is a helpful test text'
@@ -983,6 +987,7 @@ def detail_export(self, request):
 naming_collisions_router.register(r'collision', NamingCollisionViewSet, base_name="collision")
 
 
+@pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
 class TestURLNamingCollisions(TestCase):
     """
     Ref: https://github.com/encode/django-rest-framework/issues/4704
@@ -1167,6 +1172,7 @@ def custom_action(self, request, pk):
     assert inspector.get_allowed_methods(callback) == ["GET"]
 
 
+@pytest.mark.skipif(not coreapi, reason='coreapi is not installed')
 class TestAutoSchemaAllowsFilters(object):
     class MockAPIView(APIView):
         filter_backends = [filters.OrderingFilter]
