Merge pull request #2836 from ryangallen/master

kevin-brown · kevin-brown · commit 5cc0a3c2a84b · 2015-04-20T18:10:40.000-04:00
only allow integer field to accept integers and strings, fixes #2835
diff --git a/rest_framework/fields.py b/rest_framework/fields.py
@@ -682,7 +682,7 @@ def to_internal_value(self, data):
             self.fail('max_string_length')
 
         try:
-            data = int(data)
+            data = int(re.compile(r'\.0*\s*$').sub('', str(data)))
         except (ValueError, TypeError):
             self.fail('invalid')
         return data
diff --git a/tests/test_fields.py b/tests/test_fields.py
@@ -549,10 +549,13 @@ class TestIntegerField(FieldValues):
         1: 1,
         0: 0,
         1.0: 1,
-        0.0: 0
+        0.0: 0,
+        '1.0': 1
     }
     invalid_inputs = {
-        'abc': ['A valid integer is required.']
+        0.5: ['A valid integer is required.'],
+        'abc': ['A valid integer is required.'],
+        '0.5': ['A valid integer is required.']
     }
     outputs = {
         '1': 1,
