Skip to content

Commit 5ec223b

Browse files
auvipytomchristie
authored andcommitted
converted validators and write_only_fields test to pytest style (#4697)
1 parent 4b59ec2 commit 5ec223b

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

tests/test_validators.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,23 +94,20 @@ def test_updated_instance_excluded(self):
9494
def test_doesnt_pollute_model(self):
9595
instance = AnotherUniquenessModel.objects.create(code='100')
9696
serializer = AnotherUniquenessSerializer(instance)
97-
self.assertEqual(
98-
AnotherUniquenessModel._meta.get_field('code').validators, [])
97+
assert AnotherUniquenessModel._meta.get_field('code').validators == []
9998

10099
# Accessing data shouldn't effect validators on the model
101100
serializer.data
102-
self.assertEqual(
103-
AnotherUniquenessModel._meta.get_field('code').validators, [])
101+
assert AnotherUniquenessModel._meta.get_field('code').validators == []
104102

105103
def test_related_model_is_unique(self):
106104
data = {'username': 'Existing', 'email': 'new-email@example.com'}
107105
rs = RelatedModelSerializer(data=data)
108-
self.assertFalse(rs.is_valid())
109-
self.assertEqual(rs.errors,
110-
{'username': ['This field must be unique.']})
106+
assert not rs.is_valid()
107+
assert rs.errors == {'username': ['This field must be unique.']}
111108
data = {'username': 'new-username', 'email': 'new-email@example.com'}
112109
rs = RelatedModelSerializer(data=data)
113-
self.assertTrue(rs.is_valid())
110+
assert rs.is_valid()
114111

115112
def test_value_error_treated_as_not_unique(self):
116113
serializer = UniquenessIntegerSerializer(data={'integer': 'abc'})

tests/test_write_only_fields.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ def write_only_fields_are_present_on_input(self):
2020
'password': '123'
2121
}
2222
serializer = self.Serializer(data=data)
23-
self.assertTrue(serializer.is_valid())
24-
self.assertEqual(serializer.validated_data, data)
23+
assert serializer.is_valid()
24+
assert serializer.validated_data == data
2525

2626
def write_only_fields_are_not_present_on_output(self):
2727
instance = {
2828
'email': 'foo@example.com',
2929
'password': '123'
3030
}
3131
serializer = self.Serializer(instance)
32-
self.assertEqual(serializer.data, {'email': 'foo@example.com'})
32+
assert serializer.data == {'email': 'foo@example.com'}

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy