Merge pull request #2187 from loic/cosmetic_fixes

tomchristie · tomchristie · commit b440bd74be12 · 2014-12-08T09:07:57.000Z
Cosmetic fixes in the API browser HTML.
diff --git a/rest_framework/static/rest_framework/js/default.js b/rest_framework/static/rest_framework/js/default.js
@@ -24,7 +24,8 @@ prettyPrint();
 
 // Bootstrap tooltips.
 $('.js-tooltip').tooltip({
-    delay: 1000
+    delay: 1000,
+    container: 'body'
 });
 
 // Deal with rounded tab styling after tab clicks.
diff --git a/rest_framework/templates/rest_framework/login_base.html b/rest_framework/templates/rest_framework/login_base.html
@@ -21,11 +21,11 @@
                                 {% csrf_token %}
                                 <div id="div_id_username"
                                     class="clearfix control-group {% if form.username.errors %}error{% endif %}">
-                                    <div class="controls">
-                                        <label class="span4">Username:</label>
-                                        <input style="height: 25px" type="text" name="username" maxlength="100"
+                                    <div class="form-group">
+                                        <label for="id_username">Username:</label>
+                                        <input type="text" name="username" maxlength="100"
                                             autocapitalize="off"
-                                            autocorrect="off" class="span12 textinput textInput"
+                                            autocorrect="off" class="form-control textinput textInput"
                                             id="id_username" required
                                             {% if form.username.value %}value="{{ form.username.value }}"{% endif %}>
                                         {% if form.username.errors %}
@@ -36,12 +36,11 @@
                                     </div>
                                 </div>
                                     <div id="div_id_password"
-                                        class="clearfix control-group {% if form.password.errors %}error{% endif %}"
-                                        style="margin-top: 10px">
-                                        <div class="controls">
-                                        <label class="span4">Password:</label>
-                                        <input style="height: 25px" type="password" name="password" maxlength="100"
-                                            autocapitalize="off" autocorrect="off" class="span12 textinput textInput"
+                                        class="clearfix control-group {% if form.password.errors %}error{% endif %}">
+                                        <div class="form-group">
+                                        <label for="id_password">Password:</label>
+                                        <input type="password" name="password" maxlength="100"
+                                            autocapitalize="off" autocorrect="off" class="form-control textinput textInput"
                                             id="id_password" required>
                                         {% if form.password.errors %}
                                             <p class="text-error">
@@ -56,8 +55,8 @@
                                         <div class="well well-small text-error" style="border: none">{{ error }}</div>
                                     {% endfor %}
                                 {% endif %}
-                                <div class="form-actions-no-box" style="margin-top: 20px">
-                                    <input type="submit" name="submit" value="Log in" class="btn btn-primary" id="submit-id-submit">
+                                <div class="form-actions-no-box">
+                                    <input type="submit" name="submit" value="Log in" class="btn btn-primary form-control" id="submit-id-submit">
                                 </div>
                             </form>
                         </div>
diff --git a/rest_framework/templates/rest_framework/raw_data_form.html b/rest_framework/templates/rest_framework/raw_data_form.html
@@ -2,10 +2,10 @@
 {% csrf_token %}
 {{ form.non_field_errors }}
 {% for field in form %}
-    <div class="control-group">
-        {{ field.label_tag|add_class:"control-label" }}
-        <div class="controls">
-            {{ field }}
+    <div class="form-group">
+        {{ field.label_tag|add_class:"col-sm-2 control-label" }}
+        <div class="col-sm-10">
+            {{ field|add_class:"form-control" }}
             <span class="help-block">{{ field.help_text }}</span>
         </div>
     </div>
diff --git a/tests/test_authentication.py b/tests/test_authentication.py
@@ -142,7 +142,7 @@ def test_login_view_renders_on_get(self):
         cf. [#1810](https://github.com/tomchristie/django-rest-framework/pull/1810)
         """
         response = self.csrf_client.get('/auth/login/')
-        self.assertContains(response, '<label class="span4">Username:</label>')
+        self.assertContains(response, '<label for="id_username">Username:</label>')
 
     def test_post_form_session_auth_failing_csrf(self):
         """
