Test for TimeField not handling empty values

areski · areski · commit c6372e300d9f · 2016-01-11T12:12:44.000+01:00
diff --git a/rest_framework/fields.py b/rest_framework/fields.py
@@ -1139,7 +1139,7 @@ def to_representation(self, value):
         )
 
         if output_format.lower() == ISO_8601:
-            if (isinstance(value, str)):
+            if (isinstance(value, six.string_types)):
                 value = datetime.datetime.strptime(value, '%Y-%m-%d').date()
             return value.isoformat()
 
@@ -1204,7 +1204,7 @@ def to_representation(self, value):
         )
 
         if output_format.lower() == ISO_8601:
-            if (isinstance(value, str)):
+            if (isinstance(value, six.string_types)):
                 value = datetime.datetime.strptime(value, '%H:%M:%S').time()
             return value.isoformat()
         return value.strftime(output_format)
diff --git a/tests/test_fields.py b/tests/test_fields.py
@@ -1031,6 +1031,7 @@ class TestTimeField(FieldValues):
     }
     outputs = {
         datetime.time(13, 00): '13:00:00',
+        '00:00:00': '00:00:00',
         None: None,
         '': None,
     }

Original file line number	Diff line number	Diff line change
`@@ -1139,7 +1139,7 @@ def to_representation(self, value):`
`1139`	`1139`	`)`
`1140`	`1140`
`1141`	`1141`	`if output_format.lower() == ISO_8601:`
`1142`		`- if (isinstance(value, str)):`
	`1142`	`+ if (isinstance(value, six.string_types)):`
`1143`	`1143`	`value = datetime.datetime.strptime(value, '%Y-%m-%d').date()`
`1144`	`1144`	`return value.isoformat()`
`1145`	`1145`
`@@ -1204,7 +1204,7 @@ def to_representation(self, value):`
`1204`	`1204`	`)`
`1205`	`1205`
`1206`	`1206`	`if output_format.lower() == ISO_8601:`
`1207`		`- if (isinstance(value, str)):`
	`1207`	`+ if (isinstance(value, six.string_types)):`
`1208`	`1208`	`value = datetime.datetime.strptime(value, '%H:%M:%S').time()`
`1209`	`1209`	`return value.isoformat()`
`1210`	`1210`	`return value.strftime(output_format)`
Original file line number	Diff line number	Diff line change
`@@ -1031,6 +1031,7 @@ class TestTimeField(FieldValues):`
`1031`	`1031`	`}`
`1032`	`1032`	`outputs = {`
`1033`	`1033`	`datetime.time(13, 00): '13:00:00',`
	`1034`	`+ '00:00:00': '00:00:00',`
`1034`	`1035`	`None: None,`
`1035`	`1036`	`'': None,`
`1036`	`1037`	`}`