Skip to content

Descriptive error from FileUploadParser when filename not included. #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Aug 1, 2016

If a Content-Disposition including a filename= parameter is not included, then always raise a consistent and informative error. Previous behavior would be:

  • Small files raised an unhelpful and non-descriptive ParseError.
  • Large files succeeded with a randomly generated system filename.

Closes #3610.
Closes #4296.

@tomchristie tomchristie added the Bug label Aug 1, 2016
@tomchristie tomchristie added this to the 3.4.2 Release milestone Aug 1, 2016
@tomchristie tomchristie merged commit 3ef3fee into master Aug 1, 2016
@tomchristie tomchristie deleted the descriptive-error-when-upload-does-not-include-filename branch August 1, 2016 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy