-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix __pychache__/.pyc excludes when packaging #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I definitely see files from `__pycache__` as well as `.pyc` files in the package. Fixed according to https://www.reddit.com/r/Python/comments/40s8qw/simplify_your_manifestin_commands and django/django#5817
carltongibson
approved these changes
Aug 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what we have on Django Filter too
@kiss90benedek thanks! |
gunthercox
added a commit
to gunthercox/ChatterBot
that referenced
this pull request
Jan 31, 2018
StefanoChiodino
pushed a commit
to StefanoChiodino/ChatterBot
that referenced
this pull request
Jan 19, 2021
datastoreking
added a commit
to datastoreking/_Python-ChatterBot
that referenced
this pull request
Jan 31, 2022
gayanMatch
pushed a commit
to gayanMatch/chatterBot
that referenced
this pull request
May 3, 2023
AIDevMonster
added a commit
to AIDevMonster/Chatter-Bot
that referenced
this pull request
Jun 21, 2023
chohjh156
added a commit
to chohjh156/chatterbot
that referenced
this pull request
Jul 25, 2023
whiteghostDev
added a commit
to whiteghostDev/Chatter-Bot
that referenced
this pull request
Aug 6, 2023
crown0128
added a commit
to crown0128/ChatterBot
that referenced
this pull request
Sep 29, 2023
architectNinja
pushed a commit
to architectNinja/python-chatterbot
that referenced
this pull request
Nov 21, 2023
TOP-10-DEV
added a commit
to TOP-10-DEV/Chat-Bot
that referenced
this pull request
Dec 7, 2023
dark-knjn
added a commit
to dark-knjn/chatterBot
that referenced
this pull request
Jul 18, 2024
David-Cross0724
added a commit
to David-Cross0724/chatterBot
that referenced
this pull request
Jul 18, 2024
cinderella0302
added a commit
to cinderella0302/chatterBot
that referenced
this pull request
Sep 30, 2024
dev-star712
added a commit
to dev-star712/Chatter-Bot
that referenced
this pull request
Nov 11, 2024
gold-crow-997
added a commit
to gold-crow-997/chatterBot
that referenced
this pull request
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I definitely see files from
__pycache__
as well as.pyc
files in the 3.6.4 package. Fixed according to reddit and django/django#5817.