Allow ChoiceField.choices to be set dynamically
#5426
Conversation
## Description The `choices` field for the `ChoiceField` class should be able to be edited after `ChoiceField.__init__` is called. ``` field = ChoiceField(choices=[1,2]) field.choices = [1] # Should no longer allow `2` as a choice ``` Currently, you must update `choices`, `grouped_choices`, and `choice_strings_to_values` to achieve this. This P/R keeps `grouped_choices` and `choice_strings_to_values` in sync whenever the `choices` are edited.
|
Seems okay, yes. No particular reason why you should instead just override the entire field, but we could go with this? Any issues that I might be missing that this could quietly introduce, anyone? @encode/django-rest-framework-core-team Welcome to merge if anyone else okays this too. |
There was a problem hiding this comment.
This looks OK to me. (A few days mulling it and I still can't see an issue; tests pass; ...) So lets go.
Aside: I'd be inclined towards a follow-up that just made group_choices and choice_strings_to_values calculated properties. It strikes me we're storing 3 bits of state where 1 would suffice. Anyhoo...
|
@carltongibson I debated that design too; I can make another P/R to change |
Description
The
choicesfield for theChoiceFieldclass should be able to be edited after__init__is called.Currently, you must update
choices,grouped_choices, andchoice_strings_to_valuesto achieve this. This P/R keepsgrouped_choicesandchoice_strings_to_valuesin sync whenever thechoicesare edited.