Skip to content

Schema Generation: Extract Method for adjusting manual fields #5632

New issue
New issue
Closed
Closed
Schema Generation: Extract Method for adjusting manual fields#5632
Labels
EnhancementSchema Generation
@carltongibson

Description

@carltongibson
carltongibson
opened on Nov 28, 2017

Ref #5621 (comment)
Ref #5630

The logic to add/adjust manual_fields is currently inline in get_link:

django-rest-framework/rest_framework/schemas/inspectors.py

Lines 184 to 188 in c63e35c

if self._manual_fields is not None:
by_name = {f.name: f for f in fields}
for f in self._manual_fields:
by_name[f.name] = f
fields = list(by_name.values())

This should be extracted to a separate method so the logic can be re-used when users are overriding get_link

Metadata

Metadata

Assignees

No one assigned

    Labels

    EnhancementSchema Generation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy