Skip to content

Django 2.2 compat #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2019
Merged

Conversation

carltongibson
Copy link
Collaborator

No description provided.

Django 2.2 enables foreign key constraint checking on SQLite.
@tomchristie
Copy link
Member

Want to talk me through what's new here? What's with the model & migration?

@carltongibson
Copy link
Collaborator Author

As per Tim's #6422 (comment) models with FKs to models with migrations must have migrations.

So... just moving things around. It's only the CustomToken model that is the issue.

But I haven't got it quite right yet, and it's not reproducing for me locally. (So fun™)

@carltongibson carltongibson force-pushed the django-2.2-compat branch 3 times, most recently from 5491bfd to d050d16 Compare February 14, 2019 10:35
@carltongibson
Copy link
Collaborator Author

OK, spotted this. There's also a Tag model with FK to ContentType (in test_relations_generic.py). I'll update that too and we should be good.

@carltongibson carltongibson merged commit 65f5c11 into encode:master Feb 14, 2019
@carltongibson carltongibson deleted the django-2.2-compat branch February 14, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy