diff --git a/rest_framework/fields.py b/rest_framework/fields.py
index 242d0f9787..5730ca5717 100644
--- a/rest_framework/fields.py
+++ b/rest_framework/fields.py
@@ -93,9 +93,6 @@ def get_attribute(instance, attrs):
Also accepts either attribute lookup on objects or dictionary lookups.
"""
for attr in attrs:
- if instance is None:
- # Break out early if we get `None` at any point in a nested lookup.
- return None
try:
if isinstance(instance, collections.Mapping):
instance = instance[attr]
diff --git a/tests/test_serializer.py b/tests/test_serializer.py
index 91430a1932..3044d7c6b7 100644
--- a/tests/test_serializer.py
+++ b/tests/test_serializer.py
@@ -411,6 +411,19 @@ def test_default_not_used_when_in_object(self):
serializer = self.Serializer(instance)
assert serializer.data == {'has_default': 'def', 'has_default_callable': 'ghi', 'no_default': 'abc'}
+ def test_default_for_source_source(self):
+ """
+ 'default="something"' should be used when a traversed attribute is missing from input.
+ """
+ class Serializer(serializers.Serializer):
+ traversed = serializers.CharField(default='x', source='traversed.attr')
+
+ assert Serializer({}).data == {'traversed': 'x'}
+ assert Serializer({'traversed': {}}).data == {'traversed': 'x'}
+ assert Serializer({'traversed': None}).data == {'traversed': 'x'}
+
+ assert Serializer({'traversed': {'attr': 'abc'}}).data == {'traversed': 'abc'}
+
class TestCacheSerializerData:
def test_cache_serializer_data(self):
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy