feat: no-misleading-character-class support v flag (#17406)

ota-meshi · web-flow · commit 509f75395035 · 2023-07-25T14:08:50.000+02:00
* feat: `no-misleading-character-class` support `v` flag

* fix: lib/rules/utils/regular-expressions.js

* fix: iterateCharacterSequence
diff --git a/docs/src/rules/no-misleading-character-class.md b/docs/src/rules/no-misleading-character-class.md
@@ -79,6 +79,7 @@ Examples of **correct** code for this rule:
 
 /^[abc]$/
 /^[👍]$/u
+/^[\q{👶🏻}]$/v
 ```
 
 :::
diff --git a/lib/rules/no-misleading-character-class.js b/lib/rules/no-misleading-character-class.js
@@ -18,7 +18,7 @@ const { isValidWithUnicodeFlag } = require("./utils/regular-expressions");
  *
  * CharacterClassRange syntax can steal a part of character sequence,
  * so this function reverts CharacterClassRange syntax and restore the sequence.
- * @param {regexpp.AST.CharacterClassElement[]} nodes The node list to iterate character sequences.
+ * @param {import('@eslint-community/regexpp').AST.CharacterClassElement[]} nodes The node list to iterate character sequences.
  * @returns {IterableIterator<number[]>} The list of character sequences.
  */
 function *iterateCharacterSequence(nodes) {
@@ -37,6 +37,9 @@ function *iterateCharacterSequence(nodes) {
                 break;
 
             case "CharacterSet":
+            case "CharacterClass": // [[]] nesting character class
+            case "ClassStringDisjunction": // \q{...}
+            case "ExpressionCharacterClass": // [A--B]
                 if (seq.length > 0) {
                     yield seq;
                     seq = [];
@@ -144,7 +147,10 @@ module.exports = {
                     pattern,
                     0,
                     pattern.length,
-                    flags.includes("u")
+                    {
+                        unicode: flags.includes("u"),
+                        unicodeSets: flags.includes("v")
+                    }
                 );
             } catch {
 
diff --git a/lib/rules/utils/regular-expressions.js b/lib/rules/utils/regular-expressions.js
@@ -28,7 +28,7 @@ function isValidWithUnicodeFlag(ecmaVersion, pattern) {
     });
 
     try {
-        validator.validatePattern(pattern, void 0, void 0, /* uFlag = */ true);
+        validator.validatePattern(pattern, void 0, void 0, { unicode: /* uFlag = */ true });
     } catch {
         return false;
     }
diff --git a/tests/lib/rules/no-misleading-character-class.js b/tests/lib/rules/no-misleading-character-class.js
@@ -70,7 +70,14 @@ ruleTester.run("no-misleading-character-class", rule, {
         "var r = new RegExp('[Á] [ ');",
         "var r = RegExp('{ [Á]', 'u');",
         { code: "var r = new globalThis.RegExp('[Á] [ ');", env: { es2020: true } },
-        { code: "var r = globalThis.RegExp('{ [Á]', 'u');", env: { es2020: true } }
+        { code: "var r = globalThis.RegExp('{ [Á]', 'u');", env: { es2020: true } },
+
+        // ES2024
+        { code: "var r = /[👍]/v", parserOptions: { ecmaVersion: 2024 } },
+        { code: String.raw`var r = /^[\q{👶🏻}]$/v`, parserOptions: { ecmaVersion: 2024 } },
+        { code: String.raw`var r = /[🇯\q{abc}🇵]/v`, parserOptions: { ecmaVersion: 2024 } },
+        { code: "var r = /[🇯[A]🇵]/v", parserOptions: { ecmaVersion: 2024 } },
+        { code: "var r = /[🇯[A--B]🇵]/v", parserOptions: { ecmaVersion: 2024 } }
     ],
     invalid: [
 
@@ -620,6 +627,17 @@ ruleTester.run("no-misleading-character-class", rule, {
                 messageId: "zwj",
                 suggestions: null
             }]
+        },
+
+
+        // ES2024
+        {
+            code: "var r = /[[👶🏻]]/v",
+            parserOptions: { ecmaVersion: 2024 },
+            errors: [{
+                messageId: "emojiModifier",
+                suggestions: null
+            }]
         }
     ]
 });

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ function isValidWithUnicodeFlag(ecmaVersion, pattern) {`
`28`	`28`	`});`
`29`	`29`
`30`	`30`	`try {`
`31`		`- validator.validatePattern(pattern, void 0, void 0, /* uFlag = */ true);`
	`31`	`+ validator.validatePattern(pattern, void 0, void 0, { unicode: /* uFlag = */ true });`
`32`	`32`	`} catch {`
`33`	`33`	`return false;`
`34`	`34`	`}`