fix: handle null type loc in getIndexFromLoc method
#19862
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
null loc in getIndexFromLoc methodnull type loc in getIndexFromLoc method
nzakas
reviewed
Jun 17, 2025
Comment on lines
797
to
+798
| if ( | ||
| loc === null || |
There was a problem hiding this comment.
Can we add a separate error for this? The error message says what it expects but doesn't mention that loc is null. Something like, "Unexpected null argument."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Hello,
In this PR, I've added handling logic for
null-typelocto thegetIndexFromLocmethod.Currently, passing
nulltogetIndexFromLocresults in an unrelated error because accessingloc.linethrows whenlocisnull.So, I’ve updated the error message to more precisely indicate that an incorrect type was passed to the
getIndexFromLocmethod.Is there anything you'd like reviewers to focus on?