Skip to content
This repository was archived by the owner on Jun 17, 2021. It is now read-only.

Add Address.equals(address: Address) #285

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Add Address.equals(address: Address) #285

merged 1 commit into from
Jan 26, 2021

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Jan 21, 2021

This PR adds Address.equals(address: Address) along with tests to make comparison of Address objects easier.

Before:
address1.toBuffer().equals(address2.toBuffer())
After:
address1.equals(address2)

@coveralls
Copy link

coveralls commented Jan 21, 2021

Coverage Status

Coverage increased (+0.003%) to 99.307% when pulling 93c43f7 on add-address-equals into dd2882d on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.307% when pulling 93c43f7 on add-address-equals into dd2882d on master.

Copy link
Contributor

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect 🙂

@ryanio
Copy link
Contributor Author

ryanio commented Jan 26, 2021

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy