fix #3845: some incorrect error message locations

evanw · evanw · commit 78f89e41d5e8 · 2024-07-25T13:31:29.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,10 @@
 
     Previously esbuild's CLI could crash if it was invoked with flags that aren't valid for a "build" API call and the `--analyze` flag is present. This was caused by esbuild's internals attempting to add a Go plugin (which is how `--analyze` is implemented) to a null build object. The panic has been fixed in this release.
 
+* Fix incorrect location of certain error messages ([#3845](https://github.com/evanw/esbuild/issues/3845))
+
+    This release fixes a regression that caused certain errors relating to variable declarations to be reported at an incorrect location. The regression was introduced in version 0.18.7 of esbuild.
+
 ## 0.23.0
 
 **_This release deliberately contains backwards-incompatible changes._** To avoid automatically picking up releases like this, you should either be pinning the exact version of `esbuild` in your `package.json` file (recommended) or be using a version range syntax that only accepts patch upgrades such as `^0.22.0` or `~0.22.0`. See npm's documentation about [semver](https://docs.npmjs.com/cli/v6/using-npm/semver/) for more information.
diff --git a/internal/js_parser/js_parser.go b/internal/js_parser/js_parser.go
@@ -1605,7 +1605,7 @@ func (p *parser) hoistSymbols(scope *js_ast.Scope) {
 func (p *parser) declareBinding(kind ast.SymbolKind, binding js_ast.Binding, opts parseStmtOpts) {
 	js_ast.ForEachIdentifierBinding(binding, func(loc logger.Loc, b *js_ast.BIdentifier) {
 		if !opts.isTypeScriptDeclare || (opts.isNamespaceScope && opts.isExport) {
-			b.Ref = p.declareSymbol(kind, binding.Loc, p.loadNameFromRef(b.Ref))
+			b.Ref = p.declareSymbol(kind, loc, p.loadNameFromRef(b.Ref))
 		}
 	})
 }

Original file line number	Diff line number	Diff line change
`@@ -1605,7 +1605,7 @@ func (p parser) hoistSymbols(scope js_ast.Scope) {`
`1605`	`1605`	`func (p *parser) declareBinding(kind ast.SymbolKind, binding js_ast.Binding, opts parseStmtOpts) {`
`1606`	`1606`	`js_ast.ForEachIdentifierBinding(binding, func(loc logger.Loc, b *js_ast.BIdentifier) {`
`1607`	`1607`	`if !opts.isTypeScriptDeclare \|\| (opts.isNamespaceScope && opts.isExport) {`
`1608`		`- b.Ref = p.declareSymbol(kind, binding.Loc, p.loadNameFromRef(b.Ref))`
	`1608`	`+ b.Ref = p.declareSymbol(kind, loc, p.loadNameFromRef(b.Ref))`
`1609`	`1609`	`}`
`1610`	`1610`	`})`
`1611`	`1611`	`}`