From a60604680893e0441c0f71effec6c9896a69a921 Mon Sep 17 00:00:00 2001 From: Alanscut Date: Fri, 19 Jun 2020 14:57:21 +0800 Subject: [PATCH] fix issue #1339 --- lib/utils/shared-strings.js | 2 +- .../issue-1339-speciel-cell-file.spec.js | 43 +++++++++++++++++++ 2 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 spec/integration/issues/issue-1339-speciel-cell-file.spec.js diff --git a/lib/utils/shared-strings.js b/lib/utils/shared-strings.js index 205209298..c3e46af06 100644 --- a/lib/utils/shared-strings.js +++ b/lib/utils/shared-strings.js @@ -2,7 +2,7 @@ class SharedStrings { constructor() { this._values = []; this._totalRefs = 0; - this._hash = {}; + this._hash = Object.create(null); } get count() { diff --git a/spec/integration/issues/issue-1339-speciel-cell-file.spec.js b/spec/integration/issues/issue-1339-speciel-cell-file.spec.js new file mode 100644 index 000000000..0b95610ee --- /dev/null +++ b/spec/integration/issues/issue-1339-speciel-cell-file.spec.js @@ -0,0 +1,43 @@ +const ExcelJS = verquire('exceljs'); + +// this file to contain integration tests created from github issues +const TEST_XLSX_FILE_NAME = './spec/out/wb.test.xlsx'; + +describe('github issues', () => { + it('issue 1339 - Special cell value results invalid file', async () => { + const wb = new ExcelJS.stream.xlsx.WorkbookWriter({ + filename: TEST_XLSX_FILE_NAME, + useStyles: true, + useSharedStrings: true, + }); + const ws = wb.addWorksheet('Sheet1'); + const specialValues = [ + 'constructor', + 'hasOwnProperty', + 'isPrototypeOf', + 'propertyIsEnumerable', + 'toLocaleString', + 'toString', + 'valueOf', + '__defineGetter__', + '__defineSetter__', + '__lookupGetter__', + '__lookupSetter__', + '__proto__', + ]; + for (let i = 0, len = specialValues.length; i < len; i++) { + const value = specialValues[i]; + ws.addRow([value]); + ws.getCell(`B${i + 1}`).value = value; + } + await wb.commit(); + const wb2 = new ExcelJS.Workbook(); + await wb2.xlsx.readFile(TEST_XLSX_FILE_NAME); + const ws2 = wb2.getWorksheet('Sheet1'); + for (let i = 0, len = specialValues.length; i < len; i++) { + const value = specialValues[i]; + expect(ws2.getCell(`A${i + 1}`).value).to.equal(value); + expect(ws2.getCell(`B${i + 1}`).value).to.equal(value); + } + }); +}); pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy