Use _ as the divider for dynamic import name splitter. (vercel#2793)

arunoda · web-flow · commit a730b04df79e · 2017-08-17T02:25:27.000+05:30
Using - gives us some weird webpack errors.
diff --git a/server/build/babel/plugins/handle-import.js b/server/build/babel/plugins/handle-import.js
@@ -2,7 +2,7 @@
 // We've added support for SSR with this version
 import template from 'babel-template'
 import syntax from 'babel-plugin-syntax-dynamic-import'
-import { dirname, resolve } from 'path'
+import { dirname, resolve, sep } from 'path'
 import Crypto from 'crypto'
 
 const TYPE_IMPORT = 'Import'
@@ -62,8 +62,8 @@ export default () => ({
         const modulePath = getModulePath(sourceFilename, moduleName)
         const modulePathHash = Crypto.createHash('md5').update(modulePath).digest('hex')
 
-        const relativeModulePath = modulePath.replace(process.cwd(), '')
-        const name = `${relativeModulePath.replace(/[^\w]/g, '-')}-${modulePathHash}`
+        const relativeModulePath = modulePath.replace(`${process.cwd()}${sep}`, '')
+        const name = `${relativeModulePath.replace(/[^\w]/g, '_')}_${modulePathHash}`
 
         const newImport = buildImport({
           name
