Adjust the checkIfOnline check if in a corporate proxy environment

bsyk · bsyk · commit 235739ef7cf4 · 2017-08-02T09:45:15.000-07:00
If the environment variable `https_proxy` is set, test that the proxy name is resolveable rather than 'registry.yarnpkg.com'. This fixes #2832.
diff --git a/packages/create-react-app/createReactApp.js b/packages/create-react-app/createReactApp.js
@@ -47,6 +47,7 @@ const semver = require('semver');
 const dns = require('dns');
 const tmp = require('tmp');
 const unpack = require('tar-pack').unpack;
+const url = require('url');
 const hyperquest = require('hyperquest');
 
 const packageJson = require('./package.json');
@@ -613,7 +614,13 @@ function checkIfOnline(useYarn) {
   }
 
   return new Promise(resolve => {
-    dns.lookup('registry.yarnpkg.com', err => {
+    let host = 'registry.yarnpkg.com';
+    // If a proxy is defined, we likely can't resolve external hostnames.
+    // Try to resolve the proxy name as an indication of a connection.
+    if (process.env.https_proxy) {
+      host = url.parse(process.env.https_proxy).hostname;
+    }
+    dns.lookup(host, err => {
       resolve(err === null);
     });
   });
