test: migrate stream 4 to node test runner (#6062)

ilteoood · web-flow · commit 0a9aa87d3577 · 2025-04-17T09:54:35.000+02:00
diff --git a/test/stream.4.test.js b/test/stream.4.test.js
@@ -1,7 +1,6 @@
 'use strict'
 
-const t = require('tap')
-const test = t.test
+const { test } = require('node:test')
 const sget = require('simple-get').concat
 const errors = require('http-errors')
 const JSONStream = require('JSONStream')
@@ -10,7 +9,7 @@ const split = require('split2')
 const Fastify = require('..')
 const { kDisableRequestLogging } = require('../lib/symbols.js')
 
-test('Destroying streams prematurely should call abort method', t => {
+test('Destroying streams prematurely should call abort method', (t, testDone) => {
   t.plan(7)
 
   let fastify = null
@@ -23,21 +22,22 @@ test('Destroying streams prematurely should call abort method', t => {
       }
     })
   } catch (e) {
-    t.fail()
+    t.assert.fail()
   }
   const stream = require('node:stream')
   const http = require('node:http')
 
   // Test that "premature close" errors are logged with level warn
   logStream.on('data', line => {
     if (line.res) {
-      t.equal(line.msg, 'stream closed prematurely')
-      t.equal(line.level, 30)
+      t.assert.strictEqual(line.msg, 'stream closed prematurely')
+      t.assert.strictEqual(line.level, 30)
+      testDone()
     }
   })
 
   fastify.get('/', function (request, reply) {
-    t.pass('Received request')
+    t.assert.ok('Received request')
 
     let sent = false
     const reallyLongStream = new stream.Readable({
@@ -50,30 +50,30 @@ test('Destroying streams prematurely should call abort method', t => {
     })
     reallyLongStream.destroy = undefined
     reallyLongStream.close = undefined
-    reallyLongStream.abort = () => t.ok('called')
+    reallyLongStream.abort = () => t.assert.ok('called')
     reply.send(reallyLongStream)
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => { fastify.close() })
 
     const port = fastify.server.address().port
 
     http.get(`http://localhost:${port}`, function (response) {
-      t.equal(response.statusCode, 200)
+      t.assert.strictEqual(response.statusCode, 200)
       response.on('readable', function () {
         response.destroy()
       })
       // Node bug? Node never emits 'close' here.
       response.on('aborted', function () {
-        t.pass('Response closed')
+        t.assert.ok('Response closed')
       })
     })
   })
 })
 
-test('Destroying streams prematurely, log is disabled', t => {
+test('Destroying streams prematurely, log is disabled', (t, testDone) => {
   t.plan(4)
 
   let fastify = null
@@ -82,7 +82,7 @@ test('Destroying streams prematurely, log is disabled', t => {
       logger: false
     })
   } catch (e) {
-    t.fail()
+    t.assert.fail()
   }
   const stream = require('node:stream')
   const http = require('node:http')
@@ -100,30 +100,33 @@ test('Destroying streams prematurely, log is disabled', t => {
       }
     })
     reallyLongStream.destroy = true
-    reallyLongStream.close = () => t.ok('called')
+    reallyLongStream.close = () => {
+      t.assert.ok('called')
+      testDone()
+    }
     reply.send(reallyLongStream)
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => { fastify.close() })
 
     const port = fastify.server.address().port
 
     http.get(`http://localhost:${port}`, function (response) {
-      t.equal(response.statusCode, 200)
+      t.assert.strictEqual(response.statusCode, 200)
       response.on('readable', function () {
         response.destroy()
       })
       // Node bug? Node never emits 'close' here.
       response.on('aborted', function () {
-        t.pass('Response closed')
+        t.assert.ok('Response closed')
       })
     })
   })
 })
 
-test('should respond with a stream1', t => {
+test('should respond with a stream1', (t, testDone) => {
   t.plan(5)
   const fastify = Fastify()
 
@@ -135,25 +138,26 @@ test('should respond with a stream1', t => {
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => { fastify.close() })
 
     sget(`http://localhost:${fastify.server.address().port}`, function (err, response, body) {
-      t.error(err)
-      t.equal(response.headers['content-type'], 'application/json')
-      t.equal(response.statusCode, 200)
-      t.same(JSON.parse(body), [{ hello: 'world' }, { a: 42 }])
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.headers['content-type'], 'application/json')
+      t.assert.strictEqual(response.statusCode, 200)
+      t.assert.deepStrictEqual(JSON.parse(body), [{ hello: 'world' }, { a: 42 }])
+      testDone()
     })
   })
 })
 
-test('return a 404 if the stream emits a 404 error', t => {
+test('return a 404 if the stream emits a 404 error', (t, testDone) => {
   t.plan(5)
 
   const fastify = Fastify()
 
   fastify.get('/', function (request, reply) {
-    t.pass('Received request')
+    t.assert.ok('Received request')
 
     const reallyLongStream = new Readable({
       read: function () {
@@ -167,15 +171,16 @@ test('return a 404 if the stream emits a 404 error', t => {
   })
 
   fastify.listen({ port: 0 }, err => {
-    t.error(err)
-    t.teardown(() => { fastify.close() })
+    t.assert.ifError(err)
+    t.after(() => { fastify.close() })
 
     const port = fastify.server.address().port
 
     sget(`http://localhost:${port}`, function (err, response) {
-      t.error(err)
-      t.equal(response.headers['content-type'], 'application/json; charset=utf-8')
-      t.equal(response.statusCode, 404)
+      t.assert.ifError(err)
+      t.assert.strictEqual(response.headers['content-type'], 'application/json; charset=utf-8')
+      t.assert.strictEqual(response.statusCode, 404)
+      testDone()
     })
   })
 })
