Backport PR matplotlib#29907: Ensure text metric calculation always uses the text cache

tacaswell · meeseeksmachine · commit 3b50d5ce0016 · 2025-05-06T05:16:51.000Z
diff --git a/lib/matplotlib/offsetbox.py b/lib/matplotlib/offsetbox.py
@@ -794,9 +794,10 @@ def get_offset(self):
         return self._offset
 
     def get_bbox(self, renderer):
-        _, h_, d_ = renderer.get_text_width_height_descent(
-            "lp", self._text._fontproperties,
-            ismath="TeX" if self._text.get_usetex() else False)
+        _, h_, d_ = mtext._get_text_metrics_with_cache(
+            renderer, "lp", self._text._fontproperties,
+            ismath="TeX" if self._text.get_usetex() else False,
+            dpi=self.get_figure(root=True).dpi)
 
         bbox, info, yd = self._text._get_layout(renderer)
         w, h = bbox.size
diff --git a/lib/matplotlib/tests/baseline_images/test_constrainedlayout/constrained_layout10.png b/lib/matplotlib/tests/baseline_images/test_constrainedlayout/constrained_layout10.png
diff --git a/lib/matplotlib/text.py b/lib/matplotlib/text.py
@@ -678,10 +678,10 @@ def _get_rendered_text_width(self, text):
         Return the width of a given text string, in pixels.
         """
 
-        w, h, d = self._renderer.get_text_width_height_descent(
-            text,
-            self.get_fontproperties(),
-            cbook.is_math_text(text))
+        w, h, d = _get_text_metrics_with_cache(
+            self._renderer, text, self.get_fontproperties(),
+            cbook.is_math_text(text),
+            self.get_figure(root=True).dpi)
         return math.ceil(w)
 
     def _get_wrapped_text(self):
diff --git a/lib/mpl_toolkits/axisartist/axis_artist.py b/lib/mpl_toolkits/axisartist/axis_artist.py
@@ -588,8 +588,9 @@ def get_texts_widths_heights_descents(self, renderer):
             if not label.strip():
                 continue
             clean_line, ismath = self._preprocess_math(label)
-            whd = renderer.get_text_width_height_descent(
-                clean_line, self._fontproperties, ismath=ismath)
+            whd = mtext._get_text_metrics_with_cache(
+                renderer, clean_line, self._fontproperties, ismath=ismath,
+                dpi=self.get_figure(root=True).dpi)
             whd_list.append(whd)
         return whd_list
 
