refactor 424

fishercoder1534 · fishercoder1534 · commit 86cd0459e971 · 2019-03-26T07:57:16.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_424.java b/src/main/java/com/fishercoder/solutions/_424.java
@@ -34,79 +34,23 @@
  */
 public class _424 {
 
-    //credit: https://discuss.leetcode.com/topic/63494/java-12-lines-o-n-sliding-window-solution-with-explanation
-    public int characterReplacement(String s, int k) {
-        int len = s.length();
-        int[] count = new int[26];
-        int start = 0;
-        int maxCount = 0;
-        int maxLength = 0;
-        for (int end = 0; end < len; end++) {
-            maxCount = Math.max(maxCount, ++count[s.charAt(end) - 'A']);
-            while (end - start + 1 - maxCount > k) {
-                count[s.charAt(start) - 'A']--;
-                start++;
-            }
-            maxLength = Math.max(maxLength, end - start + 1);
-        }
-        return maxLength;
-    }
-
-    //this one can pass all test from test1 to test5, but tests like test6 won't pass
-    public int characterReplacement_failed_attempt(String s, int k) {
-        int longest = 0;
-        if (s == null || s.length() == 0) {
-            return 0;
-        }
-        for (int i = 0; i < s.length(); i++) {
-            int count = 1;
-            char val = s.charAt(i);
-            for (int j = i + 1; j < s.length(); j++) {
-                if (s.charAt(j) == val) {
-                    count++;
-                } else {
-                    if (k > 0) {
-                        count++;
-                        char replace = s.charAt(j);
-                        int kCounter = k - 1;
-                        for (int p = j + 1; p < s.length(); p++) {
-                            if (kCounter <= 0) {
-                                if (val == s.charAt(p)) {
-                                    count++;
-                                } else {
-                                    longest = Math.max(longest, count);
-                                    break;
-                                }
-                            } else {
-                                if (val == s.charAt(p)) {
-                                    count++;
-                                } else if (replace == s.charAt(p)) {
-                                    count++;
-                                    kCounter--;
-                                } else {
-                                    longest = Math.max(longest, count);
-                                    break;
-                                }
-                            }
-                        }
-                        if (kCounter <= 0) {
-                            longest = Math.max(longest, count);
-                            break;
-                        }
-                    } else {
-                        if (s.charAt(j) == val) {
-                            count++;
-                        } else {
-                            longest = Math.max(longest, count);
-                            break;
-                        }
-                    }
+    public static class Solution1 {
+        //credit: https://discuss.leetcode.com/topic/63494/java-12-lines-o-n-sliding-window-solution-with-explanation
+        public int characterReplacement(String s, int k) {
+            int len = s.length();
+            int[] count = new int[26];
+            int start = 0;
+            int maxCount = 0;
+            int maxLength = 0;
+            for (int end = 0; end < len; end++) {
+                maxCount = Math.max(maxCount, ++count[s.charAt(end) - 'A']);
+                while (end - start + 1 - maxCount > k) {
+                    count[s.charAt(start) - 'A']--;
+                    start++;
                 }
-                longest = Math.max(longest, count);
+                maxLength = Math.max(maxLength, end - start + 1);
             }
-            longest = Math.max(longest, count);
+            return maxLength;
         }
-        return longest;
     }
-
-}
+}
diff --git a/src/test/java/com/fishercoder/_424Test.java b/src/test/java/com/fishercoder/_424Test.java
@@ -6,26 +6,23 @@
 
 import static org.junit.Assert.assertEquals;
 
-/**
- * Created by fishercoder on 5/7/17.
- */
 public class _424Test {
-    private static _424 test;
+    private static _424.Solution1 solution1;
     private static String s;
     private static int k;
     private static int actual;
     private static int expected;
 
     @BeforeClass
     public static void setup() {
-        test = new _424();
+        solution1 = new _424.Solution1();
     }
 
     @Test
     public void test1() {
         s = "ABAB";
         k = 2;
-        actual = test.characterReplacement(s, k);
+        actual = solution1.characterReplacement(s, k);
         expected = 4;
         assertEquals(expected, actual);
     }
@@ -34,7 +31,7 @@ public void test1() {
     public void test2() {
         s = "AABABBA";
         k = 1;
-        actual = test.characterReplacement(s, k);
+        actual = solution1.characterReplacement(s, k);
         expected = 4;
         assertEquals(expected, actual);
     }
@@ -43,7 +40,7 @@ public void test2() {
     public void test3() {
         s = "AAAA";
         k = 2;
-        actual = test.characterReplacement(s, k);
+        actual = solution1.characterReplacement(s, k);
         expected = 4;
         assertEquals(expected, actual);
     }
@@ -52,7 +49,7 @@ public void test3() {
     public void test4() {
         s = "AAAB";
         k = 0;
-        actual = test.characterReplacement(s, k);
+        actual = solution1.characterReplacement(s, k);
         expected = 3;
         assertEquals(expected, actual);
     }
@@ -61,7 +58,7 @@ public void test4() {
     public void test5() {
         s = "AABA";
         k = 0;
-        actual = test.characterReplacement(s, k);
+        actual = solution1.characterReplacement(s, k);
         expected = 2;
         assertEquals(expected, actual);
     }
@@ -70,7 +67,7 @@ public void test5() {
     public void test6() {
         s = "ABBB";
         k = 2;
-        actual = test.characterReplacement(s, k);
+        actual = solution1.characterReplacement(s, k);
         expected = 4;
         assertEquals(expected, actual);
     }
