Reland licenses cpp switch #172671
Merged
Reland licenses cpp switch #172671
+34,166
−19,742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f6ad9d to
8b2846f
Compare
|
I'm actually thinking we land this on monday since I haven't heard back from the skia team about when the change will be compiled into the autoroller and monday will give us more time to react to any problems. I wish there was a better way to test the autoroller integration. |
|
cc @erock2112, this adds the autoroller script. I'm kind of assuming that GN, ninja will work on the autoroller machine because it should be getting the toolchain from the gclient sync? |
gaaclarke
commented
Jul 24, 2025
There was a problem hiding this comment.
The previous logic would also print out a diff, but that seemed pointless since the diff will show up in the PR. This script tries to be portable so it can be run from anywhere. I'm unable to test it on the autoroller machines ahead of time, I did test it on my linux machine and it works, so hopefully it works there as well.
There was a problem hiding this comment.
Move to bin/internal and it doesn't have to be "."?
There was a problem hiding this comment.
I was pushing a generic solution for the autoroller so they don't have to ship any custom logic for autoroller targets. So that requires them to not make any assumptions about the repo. This matches more something like git hooks.
|
I've heard back from the skia team, the autoroller is ready to go. |
9 tasks
a3459a4 to
bdc047f
Compare
jtmcdole
approved these changes
Jul 24, 2025
matanlurey
approved these changes
Jul 24, 2025
bdc047f to
cf5cb3c
Compare
|
autosubmit label was removed for flutter/flutter/172671, because - The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
)" This reverts commit 1dc7352.
cf5cb3c to
386cdf2
Compare
|
autosubmit label was removed for flutter/flutter/172671, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
google testing was manually set to passing, failures were unrelated to the change. the changes to the LICENSE file were manually tested previously. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 29, 2025
flutter/flutter@cfbaa18...46b097a 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900) 2025-07-29 a-siva@users.noreply.github.com Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783) 2025-07-29 chingjun@google.com Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883) 2025-07-29 flar@google.com Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804) 2025-07-28 bdero@google.com [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588) 2025-07-28 engine-flutter-autoroll@skia.org Roll Packages from 963550c to 6b2e34e (7 revisions) (flutter/flutter#172869) 2025-07-28 30870216+gaaclarke@users.noreply.github.com Reland licenses cpp switch (flutter/flutter#172671) 2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878) 2025-07-28 matej.knopp@gmail.com [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034) 2025-07-28 stuartmorgan@google.com Add `--config-only` build option for Linux and Windows (flutter/flutter#172239) 2025-07-28 magder@google.com Add Gemini Code Assist review config and style guide (flutter/flutter#172785) 2025-07-28 41930132+hellohuanlin@users.noreply.github.com [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Reason for revert: integration problems with google roller |
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
This reverts commit 7063ea1.
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
<!-- start_original_pr_link --> Reverts: #172671 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: gaaclarke <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: integration problems with google roller <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: gaaclarke <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {matanlurey, jtmcdole} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: changes since last land: 1) Now the license checker can trim matched licenses to remove regions that aren't apropos 1) There is a `.autoroller-preupload.sh` script that should update the LICENSE file when the autoroller executes relies on: - #172655 - https://skia-review.googlesource.com/c/buildbot/+/1025936 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9695) flutter/flutter@cfbaa18...46b097a 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900) 2025-07-29 a-siva@users.noreply.github.com Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783) 2025-07-29 chingjun@google.com Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883) 2025-07-29 flar@google.com Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804) 2025-07-28 bdero@google.com [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588) 2025-07-28 engine-flutter-autoroll@skia.org Roll Packages from 963550c to 6b2e34e (7 revisions) (flutter/flutter#172869) 2025-07-28 30870216+gaaclarke@users.noreply.github.com Reland licenses cpp switch (flutter/flutter#172671) 2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878) 2025-07-28 matej.knopp@gmail.com [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034) 2025-07-28 stuartmorgan@google.com Add `--config-only` build option for Linux and Windows (flutter/flutter#172239) 2025-07-28 magder@google.com Add Gemini Code Assist review config and style guide (flutter/flutter#172785) 2025-07-28 41930132+hellohuanlin@users.noreply.github.com [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes since last land:
.autoroller-preupload.shscript that should update the LICENSE file when the autoroller executesrelies on:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.