fix(@formatjs/cli-lib): handle parsing error during verification

longlho · longlho · commit ddca2c22899c · 2025-01-17T11:34:48.000-05:00
diff --git a/packages/cli-lib/src/verify/checkStructuralEquality.ts b/packages/cli-lib/src/verify/checkStructuralEquality.ts
@@ -4,6 +4,7 @@ import {
   parse,
 } from '@formatjs/icu-messageformat-parser'
 import {debug, writeStderr} from '../console_utils'
+import {error} from 'console'
 
 /**
  * Flatten nested obj into list of keys, delimited by `.`
@@ -38,26 +39,30 @@ export async function checkStructuralEquality(
   const enUSMessages = Object.entries(flatten(enUSContent)).reduce<
     Record<string, MessageFormatElement[]>
   >((all, [key, value]) => {
-    all[key] = parse(value)
+    try {
+      all[key] = parse(value)
+    } catch (e) {
+      error('Error parsing message', key, value, e)
+    }
     return all
   }, {})
   return Object.entries(translationFilesContents)
     .filter(([locale]) => locale !== sourceLocale)
     .reduce<boolean>((result, [locale, content]) => {
-      const localeMessages = Object.entries(flatten(content)).reduce<
-        Record<string, MessageFormatElement[]>
-      >((all, [key, value]) => {
-        all[key] = parse(value)
-        return all
-      }, {})
+      const localeMessages = flatten(content)
 
       const problematicKeys = Object.keys(enUSMessages).filter(k => {
         if (!localeMessages[k]) {
           return false
         }
         const enUSMessage = enUSMessages[k]
-        const localeMessage = localeMessages[k]
-        return !isStructurallySame(enUSMessage, localeMessage)
+        try {
+          const localeMessage = parse(localeMessages[k])
+          return !isStructurallySame(enUSMessage, localeMessage)
+        } catch (e) {
+          error('Error comparing message', k, enUSMessage, localeMessages[k], e)
+          return true
+        }
       })
 
       if (!problematicKeys.length) {
diff --git a/packages/cli/integration-tests/verify/structural-equality/fixtures2/en-US.json b/packages/cli/integration-tests/verify/structural-equality/fixtures2/en-US.json
@@ -4,5 +4,6 @@
   "3": "bar {var, number}",
   "4": "bar {var} {var2, number} {var3, date} {var4, time}",
   "5": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}}",
-  "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} <b>foo</b>"
+  "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} <b>foo</b>",
+  "7": "bb"
 }
diff --git a/packages/cli/integration-tests/verify/structural-equality/fixtures2/fr-FR.json b/packages/cli/integration-tests/verify/structural-equality/fixtures2/fr-FR.json
@@ -4,5 +4,6 @@
   "3": "bar {var, date}",
   "4": "bar {var} {var2, number} {var3, date} {var5, time}",
   "5": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}}",
-  "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} foo"
+  "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} foo",
+  "7": "malform {a"
 }

Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,6 @@`
`4`	`4`	`"3": "bar {var, number}",`
`5`	`5`	`"4": "bar {var} {var2, number} {var3, date} {var4, time}",`
`6`	`6`	`"5": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}}",`
`7`		`- "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} <b>foo</b>"`
	`7`	`+ "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} <b>foo</b>",`
	`8`	`+ "7": "bb"`
`8`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,6 @@`
`4`	`4`	`"3": "bar {var, date}",`
`5`	`5`	`"4": "bar {var} {var2, number} {var3, date} {var5, time}",`
`6`	`6`	`"5": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}}",`
`7`		`- "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} foo"`
	`7`	`+ "6": "bar {var} {var2, number} {var3, date} {var4, time} {var5, plural, one {# foo} other {# foos}} foo",`
	`8`	`+ "7": "malform {a"`
`8`	`9`	`}`