From bd65a2b74621655fda3ac76f6cef3728556595d0 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Tue, 5 Nov 2019 05:22:14 +0100 Subject: [PATCH 1/2] Travis CI add Python 3.7, 3.8 find undefined names https://flake8.pycqa.org/en/latest/user/error-codes.html On the flake8 test selection, this PR does _not_ focus on "_style violations_" (the majority of flake8 error codes that [__psf/black__](https://github.com/psf/black) can autocorrect). Instead these tests are focus on runtime safety and correctness: * E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST). Often these issues are a sign of unused code or code that has not been ported to Python 3. These would be compile-time errors in a compiled language but in a dynamic language like Python they result in the script halting/crashing on the user. * F63 tests are usually about the confusion between identity and equality in Python. Use ==/!= to compare str, bytes, and int literals is the classic case. These are areas where __a == b__ is True but __a is b__ is False (or vice versa). Python >= 3.8 will raise SyntaxWarnings on these instances. * F7 tests logic errors and syntax errors in type hints * F82 tests are almost always _undefined names_ which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3. These also would be compile-time errors in a compiled language but in Python a __NameError__ is raised which will halt/crash the script on the user. --- .travis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index ad8ab23d..1e5d989a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,11 +1,10 @@ language: python -sudo: true - python: - - "3.4" - "3.5" - "3.6" + - "3.7" + - "3.8" before_install: - sudo apt-get -qq update @@ -13,7 +12,8 @@ before_install: - sudo chmod a+rw /builds install: - - pip3 install -r requirements.txt + - pip3 install flake8 -r requirements.txt + - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics - sudo env "PATH=$PATH" make clean - make all - sudo env "PATH=$PATH" make install From 290aa75a4dbfdeff494c2cc5ad78c96a46d83c70 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Tue, 5 Nov 2019 18:10:22 +0100 Subject: [PATCH 2/2] Rerun the tests --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1e5d989a..071809de 100644 --- a/.travis.yml +++ b/.travis.yml @@ -13,7 +13,7 @@ before_install: install: - pip3 install flake8 -r requirements.txt - - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics + - flake8 . --select=E9,F63,F7,F82 --show-source --statistics - sudo env "PATH=$PATH" make clean - make all - sudo env "PATH=$PATH" make install pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy