Skip to content

Commit 2059487

Browse files
committed
Consider unsuccessful analysis in non-Action step config error
1 parent 8b31be2 commit 2059487

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

lib/init-action-post-helper.js

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action-post-helper.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/init-action-post-helper.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,13 @@ export async function tryUploadSarifIfRunFailed(
127127
logger: Logger,
128128
): Promise<UploadFailedSarifResult> {
129129
if (process.env[EnvVar.ANALYZE_DID_COMPLETE_SUCCESSFULLY] !== "true") {
130-
// At this point, if the job status has not been set previously, but we
131-
// know that analyze didn't complete successfully, we consider the job
132-
// failed — we can't tell if the failure was due to configuration error.
130+
// If analyze didn't complete successfully and the job status hasn't
131+
// already been set to Failure/ConfigurationError previously, this
132+
// means that something along the way failed in a step that is not
133+
// owned by the Action. This is considered configuration error.
133134
core.exportVariable(
134135
EnvVar.JOB_STATUS,
135-
process.env[EnvVar.JOB_STATUS] ?? JobStatus.Failure,
136+
process.env[EnvVar.JOB_STATUS] ?? JobStatus.ConfigurationError,
136137
);
137138
try {
138139
return await maybeUploadFailedSarif(

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy