Skip to content

Commit 82edfe2

Browse files
authored
Merge pull request #2246 from github/koesie10/remove-incorrect-log
Remove incorrect log message
2 parents 8786e1f + 5d73b1b commit 82edfe2

File tree

6 files changed

+7
-14
lines changed

6 files changed

+7
-14
lines changed

lib/upload-lib.js

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/upload-lib.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/upload-lib.test.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/upload-lib.test.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/upload-lib.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ test("validate correct payload used for push, PR merge commit, and PR head", asy
4242
undefined,
4343
["CodeQL", "eslint"],
4444
"mergeBaseCommit",
45-
getRunnerLogger(true),
4645
);
4746
// Not triggered by a pull request
4847
t.falsy(pushPayload.base_ref);
@@ -66,7 +65,6 @@ test("validate correct payload used for push, PR merge commit, and PR head", asy
6665
undefined,
6766
["CodeQL", "eslint"],
6867
"mergeBaseCommit",
69-
getRunnerLogger(true),
7068
);
7169
// Uploads for a merge commit use the merge base
7270
t.deepEqual(prMergePayload.base_ref, "refs/heads/master");
@@ -84,7 +82,6 @@ test("validate correct payload used for push, PR merge commit, and PR head", asy
8482
undefined,
8583
["CodeQL", "eslint"],
8684
"mergeBaseCommit",
87-
getRunnerLogger(true),
8885
);
8986
// Uploads for the head use the PR base
9087
t.deepEqual(prHeadPayload.base_ref, "refs/heads/master");

src/upload-lib.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,9 +421,7 @@ export function buildPayload(
421421
environment: string | undefined,
422422
toolNames: string[],
423423
mergeBaseCommitOid: string | undefined,
424-
logger: Logger,
425424
) {
426-
logger.info(`Combining SARIF files using CLI`);
427425
const payloadObj = {
428426
commit_oid: commitOid,
429427
ref,
@@ -537,7 +535,6 @@ async function uploadFiles(
537535
environment,
538536
toolNames,
539537
await actionsUtil.determineMergeBaseCommitOid(),
540-
logger,
541538
);
542539

543540
// Log some useful debug info about the info

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy