Skip to content

Commit b24bd4a

Browse files
committed
Don't fail post start-proxy action if killing the proxy process fails
Otherwise logs won't get uploaded as artifact, even in debug mode
1 parent 6e35f86 commit b24bd4a

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

lib/start-proxy-action-post.js

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/start-proxy-action-post.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/start-proxy-action-post.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ async function runWrapper() {
2222
// Kill the running proxy
2323
const pid = core.getState("proxy-process-pid");
2424
if (pid) {
25-
process.kill(Number(pid));
25+
try {
26+
process.kill(Number(pid));
27+
} catch (error) {
28+
logger.error(`Failed to kill proxy process: ${getErrorMessage(error)}`);
29+
}
2630
}
2731

2832
const config = await configUtils.getConfig(

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy