Rename defaultQueryFilters

cklin · cklin · commit f5304e7bf5e4 · 2025-06-19T12:19:28.000-07:00
This commit renames AugmentationProperties.defaultQueryFilters to
extraQueryExclusions, and changes its type to ExcludeQueryFilter[]. It
matters whether we are adding query inclusions or exclusions, and this
renaming makes that distinction clearer.
diff --git a/src/codeql.ts b/src/codeql.ts
@@ -1266,7 +1266,7 @@ async function generateCodeScanningConfig(
   }
 
   augmentedConfig["query-filters"] = [
-    ...(config.augmentationProperties.defaultQueryFilters || []),
+    ...(config.augmentationProperties.extraQueryExclusions || []),
     ...(augmentedConfig["query-filters"] || []),
   ];
   if (augmentedConfig["query-filters"]?.length === 0) {
diff --git a/src/config-utils.ts b/src/config-utils.ts
@@ -186,9 +186,9 @@ export interface AugmentationProperties {
   packsInput?: string[];
 
   /**
-   * Default query filters to apply to the queries in the config.
+   * Extra query exclusions to append to the config.
    */
-  defaultQueryFilters?: QueryFilter[];
+  extraQueryExclusions?: ExcludeQueryFilter[];
 }
 
 /**
@@ -201,7 +201,7 @@ export const defaultAugmentationProperties: AugmentationProperties = {
   packsInput: undefined,
   queriesInput: undefined,
   qualityQueriesInput: undefined,
-  defaultQueryFilters: [],
+  extraQueryExclusions: [],
 };
 export type Packs = Partial<Record<Language, string[]>>;
 
@@ -671,9 +671,11 @@ export async function calculateAugmentation(
     false,
   );
 
-  const defaultQueryFilters: QueryFilter[] = [];
+  const extraQueryExclusions: ExcludeQueryFilter[] = [];
   if (await shouldPerformDiffInformedAnalysis(codeql, features, logger)) {
-    defaultQueryFilters.push({ exclude: { tags: "exclude-from-incremental" } });
+    extraQueryExclusions.push({
+      exclude: { tags: "exclude-from-incremental" },
+    });
   }
 
   return {
@@ -682,7 +684,7 @@ export async function calculateAugmentation(
     queriesInput,
     queriesInputCombines,
     qualityQueriesInput,
-    defaultQueryFilters,
+    extraQueryExclusions,
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1266,7 +1266,7 @@ async function generateCodeScanningConfig(`
`1266`	`1266`	`}`
`1267`	`1267`
`1268`	`1268`	`augmentedConfig["query-filters"] = [`
`1269`		`- ...(config.augmentationProperties.defaultQueryFilters \|\| []),`
	`1269`	`+ ...(config.augmentationProperties.extraQueryExclusions \|\| []),`
`1270`	`1270`	`...(augmentedConfig["query-filters"] \|\| []),`
`1271`	`1271`	`];`
`1272`	`1272`	`if (augmentedConfig["query-filters"]?.length === 0) {`