Skip to content

Allow omitting the autobuild Action when build mode specified #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 8, 2024
Merged

Allow omitting the autobuild Action when build mode specified #2120

merged 5 commits into from
Feb 8, 2024

Conversation

henrymercer
Copy link
Contributor

This PR enables users to omit the autobuild Action when the build mode is specified and the CLI supports the traceCommandUseBuildMode feature (available in CodeQL CLI 2.16.2 and later). This will remove redundancy and reduce the possibility for errors.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 7, 2024 13:31
angelapwen
angelapwen previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like how simple that test was 💖

@henrymercer henrymercer force-pushed the henrymercer/no-autobuild-action-necessary-with-build-mode branch from 3bd00e8 to f3ced61 Compare February 8, 2024 16:00
@henrymercer
Copy link
Contributor Author

@angelapwen I added a couple more tests for the other build modes. Would you mind taking another look?

angelapwen
angelapwen approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tests look good to me! Should this have a changelog note? Or will we wait for a general larger-scale announcement of the new build modes?

@henrymercer
Copy link
Contributor Author

Right now, this is just for internal testing. Once we've finished testing, we can remove all the internal labels and add a changelog note with all the changes.

@henrymercer henrymercer enabled auto-merge February 8, 2024 16:16
@henrymercer henrymercer merged commit fc9f9e5 into main Feb 8, 2024
@henrymercer henrymercer deleted the henrymercer/no-autobuild-action-necessary-with-build-mode branch February 8, 2024 16:23
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Merged
8 tasks
@henrymercer henrymercer mentioned this pull request Feb 13, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @angelapwen
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy