From dafc7dd67c104236ce73a54af7792cd97942ba82 Mon Sep 17 00:00:00 2001 From: Angela P Wen Date: Tue, 8 Oct 2024 13:50:31 -0700 Subject: [PATCH] PR Checks: update artifacts tests We are planning to make the default behavior of the `CODEQL_ACTION_ARTIFACT_V4_UPGRADE` feature flag to be true. This change updates our debug artifact PR checks so that the relevant environment variable is set to `true`, and changes the `debug-artifacts-upgrade` test to `debug-artifacts-legacy` test. --- .github/workflows/debug-artifacts-failure.yml | 3 ++- ...bug-artifacts-upgrade.yml => debug-artifacts-legacy.yml} | 6 +++--- .github/workflows/debug-artifacts.yml | 3 ++- 3 files changed, 7 insertions(+), 5 deletions(-) rename .github/workflows/{debug-artifacts-upgrade.yml => debug-artifacts-legacy.yml} (94%) diff --git a/.github/workflows/debug-artifacts-failure.yml b/.github/workflows/debug-artifacts-failure.yml index 871f0070c6..bcc38d28aa 100644 --- a/.github/workflows/debug-artifacts-failure.yml +++ b/.github/workflows/debug-artifacts-failure.yml @@ -3,6 +3,7 @@ name: PR Check - Debug artifacts after failure env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + CODEQL_ACTION_ARTIFACT_V4_UPGRADE: true on: push: branches: @@ -61,7 +62,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Download all artifacts - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 - name: Check expected artifacts exist shell: bash run: | diff --git a/.github/workflows/debug-artifacts-upgrade.yml b/.github/workflows/debug-artifacts-legacy.yml similarity index 94% rename from .github/workflows/debug-artifacts-upgrade.yml rename to .github/workflows/debug-artifacts-legacy.yml index 87ec73bd99..48fe6bd807 100644 --- a/.github/workflows/debug-artifacts-upgrade.yml +++ b/.github/workflows/debug-artifacts-legacy.yml @@ -1,9 +1,9 @@ # Checks logs, SARIF, and database bundle debug artifacts exist and are accessible -# with download-artifact@v4 when CODEQL_ACTION_ARTIFACT_V4_UPGRADE is set to true. +# with download-artifact@v3 when CODEQL_ACTION_ARTIFACT_V4_UPGRADE is set to false. name: PR Check - Debug artifact upload using artifact@v2 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - CODEQL_ACTION_ARTIFACT_V4_UPGRADE: true + CODEQL_ACTION_ARTIFACT_V4_UPGRADE: false on: push: branches: @@ -69,7 +69,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Download all artifacts - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v3 - name: Check expected artifacts exist shell: bash run: | diff --git a/.github/workflows/debug-artifacts.yml b/.github/workflows/debug-artifacts.yml index c06569a126..19d11ee2f9 100644 --- a/.github/workflows/debug-artifacts.yml +++ b/.github/workflows/debug-artifacts.yml @@ -2,6 +2,7 @@ name: PR Check - Debug artifact upload env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + CODEQL_ACTION_ARTIFACT_V4_UPGRADE: true on: push: branches: @@ -67,7 +68,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Download all artifacts - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 - name: Check expected artifacts exist shell: bash run: | pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy