Remove existing assets if the size does not match.

chrisgavin · chrisgavin · commit 5718855e2e9a · 2022-04-06T16:58:32.000+01:00
diff --git a/internal/push/push.go b/internal/push/push.go
@@ -300,8 +300,16 @@ func (pushService *pushService) uploadReleaseAsset(release *github.RepositoryRel
 func (pushService *pushService) createOrUpdateReleaseAsset(release *github.RepositoryRelease, existingAssets []*github.ReleaseAsset, assetPathStat os.FileInfo) error {
 	for _, existingAsset := range existingAssets {
 		if existingAsset.GetName() == assetPathStat.Name() {
-			if int64(existingAsset.GetSize()) == assetPathStat.Size() {
+			actualSize := int64(existingAsset.GetSize())
+			expectedSize := assetPathStat.Size()
+			if actualSize == expectedSize {
 				return nil
+			} else {
+				log.Warnf("Removing existing release asset %s because it was only partially-uploaded (had size %d, but should have been %d)...", existingAsset.GetName(), actualSize, expectedSize)
+				_, err := pushService.githubEnterpriseClient.Repositories.DeleteReleaseAsset(pushService.ctx, pushService.destinationRepositoryOwner, pushService.destinationRepositoryName, existingAsset.GetID())
+				if err != nil {
+					return errors.Wrap(err, "Error deleting existing release asset.")
+				}
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -300,8 +300,16 @@ func (pushService pushService) uploadReleaseAsset(release github.RepositoryRel`
`300`	`300`	`func (pushService pushService) createOrUpdateReleaseAsset(release github.RepositoryRelease, existingAssets []*github.ReleaseAsset, assetPathStat os.FileInfo) error {`
`301`	`301`	`for _, existingAsset := range existingAssets {`
`302`	`302`	`if existingAsset.GetName() == assetPathStat.Name() {`
`303`		`- if int64(existingAsset.GetSize()) == assetPathStat.Size() {`
	`303`	`+ actualSize := int64(existingAsset.GetSize())`
	`304`	`+ expectedSize := assetPathStat.Size()`
	`305`	`+ if actualSize == expectedSize {`
`304`	`306`	`return nil`
	`307`	`+ } else {`
	`308`	`+ log.Warnf("Removing existing release asset %s because it was only partially-uploaded (had size %d, but should have been %d)...", existingAsset.GetName(), actualSize, expectedSize)`
	`309`	`+ _, err := pushService.githubEnterpriseClient.Repositories.DeleteReleaseAsset(pushService.ctx, pushService.destinationRepositoryOwner, pushService.destinationRepositoryName, existingAsset.GetID())`
	`310`	`+ if err != nil {`
	`311`	`+ return errors.Wrap(err, "Error deleting existing release asset.")`
	`312`	`+ }`
`305`	`313`	`}`
`306`	`314`	`}`
`307`	`315`	`}`