Merge pull request #71 from github/move-error-check

chrisgavin · web-flow · commit d451bb4fa69a · 2022-06-14T15:22:02.000+02:00
Move an error check to a more correct location.
diff --git a/internal/push/push.go b/internal/push/push.go
@@ -324,15 +324,15 @@ func (pushService *pushService) createOrUpdateReleaseAsset(release *github.Repos
 	}
 	log.Debugf("Uploading release asset %s...", assetPathStat.Name())
 	assetFile, err := os.Open(pushService.cacheDirectory.AssetPath(release.GetTagName(), assetPathStat.Name()))
+	if err != nil {
+		return errors.Wrap(err, "Error opening release asset.")
+	}
 	defer assetFile.Close()
 	progressReader := &ioprogress.Reader{
 		Reader:   assetFile,
 		Size:     assetPathStat.Size(),
 		DrawFunc: ioprogress.DrawTerminalf(os.Stderr, ioprogress.DrawTextFormatBytes),
 	}
-	if err != nil {
-		return errors.Wrap(err, "Error opening release asset.")
-	}
 	_, _, err = pushService.uploadReleaseAsset(release, assetPathStat, progressReader)
 	if err != nil {
 		return errors.Wrap(err, "Error uploading release asset.")
