From 45e8d083c82f1aadf56be65638eb4f4fb1452300 Mon Sep 17 00:00:00 2001 From: Sigmavirus24 Date: Sun, 27 May 2012 18:49:11 -0400 Subject: [PATCH 1/5] Correct some grammar. --- content/v3/orgs/teams.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/v3/orgs/teams.md b/content/v3/orgs/teams.md index 8fce152fe7..84eeb9161b 100644 --- a/content/v3/orgs/teams.md +++ b/content/v3/orgs/teams.md @@ -44,10 +44,10 @@ repo\_names permission : _Optional_ **string** - `pull` - team members can pull, but not push or administer this + `pull` - team members can pull, but not push or administer these repositories. **Default** - `push` - team members can pull and push, but not administer this + `push` - team members can pull and push, but not administer these repositores. `admin` - team members can pull, push and administer these From a9fe7a1c5ded8a5cdced2262f24afc95870cd884 Mon Sep 17 00:00:00 2001 From: Sigmavirus24 Date: Mon, 28 May 2012 08:16:48 -0400 Subject: [PATCH 2/5] Correct ORG url. $ curl "https://api.github.com/orgs/github" { "public_gists": 0, "type": "Organization", "public_repos": 55, "url": "https://api.github.com/orgs/github", "blog": "https://github.com/about", "avatar_url": "https://secure.gravatar.com/avatar/...", "company": null, "login": "github", "email": "support@github.com", "followers": 674, "name": "GitHub", "created_at": "2008-05-11T04:37:31Z", "location": "San Francisco, CA", "id": 9919, "following": 0, "html_url": "https://github.com/github" } Note that url is not https://api.github.com/orgs/1 (or any numeral for that matter). This holds the pattern of https://api.github.com/users/github (I shortened the avatar_url link since it wasn't relevant.) --- lib/resources.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/resources.rb b/lib/resources.rb index df7eb8936d..c452339799 100644 --- a/lib/resources.rb +++ b/lib/resources.rb @@ -349,7 +349,7 @@ def json(key) ORG = { "login" => "github", "id" => 1, - "url" => "https://api.github.com/orgs/1", + "url" => "https://api.github.com/orgs/github", "avatar_url" => "https://github.com/images/error/octocat_happy.gif" } From a24ee36abd7ed83c3c505be08791d4e1d9f3922d Mon Sep 17 00:00:00 2001 From: Sigmavirus24 Date: Mon, 28 May 2012 08:29:52 -0400 Subject: [PATCH 3/5] Wrong status code documented. API actually returns status code 200. --- content/v3/orgs/teams.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/v3/orgs/teams.md b/content/v3/orgs/teams.md index 84eeb9161b..22ce5923bd 100644 --- a/content/v3/orgs/teams.md +++ b/content/v3/orgs/teams.md @@ -84,7 +84,7 @@ permission ### Response -<%= headers 201 %> +<%= headers 200 %> <%= json(:full_team) %> ## Delete team From 820c3bd546d4091ae4841c44a9e3d66eec61193f Mon Sep 17 00:00:00 2001 From: Sigmavirus24 Date: Mon, 28 May 2012 23:52:24 -0400 Subject: [PATCH 4/5] Change commits based on my experience. So far, just from looking at commits on Pull Requests, it seems as if the 'author' and 'committer' fields are returning USER like data structures instead of the structure that was there previously. --- lib/resources.rb | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/resources.rb b/lib/resources.rb index c452339799..2fad814e48 100644 --- a/lib/resources.rb +++ b/lib/resources.rb @@ -568,16 +568,8 @@ def json(key) COMMIT = { "sha" => "7638417db6d59f3c431d3e1f261cc637155684cd", "url" => "https://api.github.com/repos/octocat/Hello-World/git/commits/7638417db6d59f3c431d3e1f261cc637155684cd", - "author" => { - "date" => "2010-04-10T14:10:01-07:00", - "name" => "Scott Chacon", - "email" => "schacon@gmail.com" - }, - "committer" => { - "date" => "2010-04-10T14:10:01-07:00", - "name" => "Scott Chacon", - "email" => "schacon@gmail.com" - }, + "author" => USER, + "committer" => USER, "message" => "added readme, because im a good github citizen\n", "tree" => { "url" => "https://api.github.com/repos/octocat/Hello-World/git/trees/691272480426f78a0138979dd3ce63b77f706feb", From bf1ff3dd954dbc1468c5024e07c4d0c192023da7 Mon Sep 17 00:00:00 2001 From: Sigmavirus24 Date: Tue, 29 May 2012 23:09:48 -0400 Subject: [PATCH 5/5] Add Response section to "Create a Reference". I'm not entirely sure yet that this is the response that is sent, but I'm guessing that it is. I would have expected this to be documented, but I hope this will get the attention of someone who can fix it if it isn't correct. --- content/v3/git/refs.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/content/v3/git/refs.md b/content/v3/git/refs.md index 169a672328..d57b8692d9 100644 --- a/content/v3/git/refs.md +++ b/content/v3/git/refs.md @@ -55,6 +55,11 @@ sha <%= json "ref"=>"refs/heads/master",\ "sha"=>"827efc6d56897b048c772eb4087f854f46256132" %> +### Response + +<%= headers 201 %> +<%= json :refs %> + ## Update a Reference PATCH /repos/:user/:repo/git/refs/:ref pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy