Fix bug in get-role

khiga8 · khiga8 · commit 19e4ba9d5bad · 2023-09-26T10:34:38.000-04:00
diff --git a/lib/utils/get-role.js b/lib/utils/get-role.js
@@ -46,6 +46,8 @@ function getRole(context, node) {
   const explicitRole = getLiteralPropValue(getProp(node.attributes, 'role'))
   if (explicitRole) {
     return explicitRole
+  } else if (getProp(node.attributes, 'role')) { // If role is set to anything other than a literal prop
+    return undefined
   }
 
   // Assemble a key for looking-up the element’s role in the `elementRolesMap`
diff --git a/tests/utils/get-role.js b/tests/utils/get-role.js
@@ -13,8 +13,8 @@ describe('getRole', function () {
   })
 
   it('returns undefined when role is set to non-literal expression', function () {
-    // <Box role={isNavigationOpen ? 'generic' : 'navigation'} />
-    const node = mockJSXOpeningElement('Box', [
+    // <div role={isNavigationOpen ? 'generic' : 'navigation'} />
+    const node = mockJSXOpeningElement('div', [
       mockJSXConditionalAttribute('role', 'isNavigationOpen', 'generic', 'navigation'),
     ])
     expect(getRole({}, node)).to.equal(undefined)

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,8 @@ function getRole(context, node) {`
`46`	`46`	`const explicitRole = getLiteralPropValue(getProp(node.attributes, 'role'))`
`47`	`47`	`if (explicitRole) {`
`48`	`48`	`return explicitRole`
	`49`	`+ } else if (getProp(node.attributes, 'role')) { // If role is set to anything other than a literal prop`
	`50`	`+ return undefined`
`49`	`51`	`}`
`50`	`52`
`51`	`53`	// Assemble a key for looking-up the element’s role in the `elementRolesMap`