Fix registries deletion bug and add regression test

Copilot · zkoppert · Copilot · commit f4a8eecd86bf · 2025-07-08T23:41:48.000Z
Co-authored-by: zkoppert &lt;6935431+zkoppert@users.noreply.github.com&gt;
diff --git a/dependabot_file.py b/dependabot_file.py
@@ -11,7 +11,6 @@
 # Define data structure for dependabot.yaml
 data = {
     "version": 2,
-    "registries": {},
     "updates": [],
 }
 
@@ -60,8 +59,6 @@ def make_dependabot_config(
             dependabot_config["updates"][-1].update(
                 {"registries": [SingleQuotedScalarString(ecosystem)]}
             )
-    else:
-        dependabot_config.pop("registries", None)
 
     if schedule_day:
         dependabot_config["updates"][-1].update(
diff --git a/test_dependabot_file.py b/test_dependabot_file.py
@@ -819,6 +819,56 @@ def test_build_dependabot_file_with_labels(self):
             )
             self.assertEqual(result, expected_result)
 
+    def test_build_dependabot_file_preserves_existing_registries(self):
+        """Test that existing registries are preserved when adding new ecosystems"""
+        repo = MagicMock()
+        repo.file_contents.side_effect = lambda filename: filename == "Gemfile"
+        
+        # Create existing config with registries but no bundler ecosystem
+        existing_config = MagicMock()
+        existing_config.content = base64.b64encode(
+            b"""
+version: 2
+registries:
+  gradle-artifactory:
+    type: maven-repository
+    url: https://acme.jfrog.io/artifactory/my-gradle-registry
+    username: octocat
+    password: ${{secrets.MY_ARTIFACTORY_PASSWORD}}
+updates:
+  - package-ecosystem: "npm"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+"""
+        )
+        
+        expected_result = yaml.load(
+            b"""
+version: 2
+registries:
+  gradle-artifactory:
+    type: maven-repository
+    url: https://acme.jfrog.io/artifactory/my-gradle-registry
+    username: octocat
+    password: ${{secrets.MY_ARTIFACTORY_PASSWORD}}
+updates:
+  - package-ecosystem: "npm"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+  - package-ecosystem: 'bundler'
+    directory: '/'
+    schedule:
+      interval: 'weekly'
+"""
+        )
+        
+        result = build_dependabot_file(
+            repo, False, [], {}, existing_config, "weekly", "", [], None
+        )
+        self.assertEqual(result, expected_result)
+
 
 if __name__ == "__main__":
     unittest.main()

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`	`# Define data structure for dependabot.yaml`
`12`	`12`	`data = {`
`13`	`13`	`"version": 2,`
`14`		`- "registries": {},`
`15`	`14`	`"updates": [],`
`16`	`15`	`}`
`17`	`16`
`@@ -60,8 +59,6 @@ def make_dependabot_config(`
`60`	`59`	`dependabot_config["updates"][-1].update(`
`61`	`60`	`{"registries": [SingleQuotedScalarString(ecosystem)]}`
`62`	`61`	`)`
`63`		`- else:`
`64`		`- dependabot_config.pop("registries", None)`
`65`	`62`
`66`	`63`	`if schedule_day:`
`67`	`64`	`dependabot_config["updates"][-1].update(`