Move setup out of stub block

mtodd · mtodd · commit d32bcfbb0dbe · 2014-10-17T12:19:21.000-07:00
The stub was affecting the search for the groups, tada.
diff --git a/test/membership_validators/active_directory_test.rb b/test/membership_validators/active_directory_test.rb
@@ -18,45 +18,50 @@ def make_validator(groups)
   end
 
   def test_validates_user_in_group
+    validator = make_validator(%w(nested-group1))
+
     @ldap.stub :search, [@entry] do
-      validator = make_validator(%w(nested-group1))
       assert validator.perform(@entry)
     end
   end
 
   def test_validates_user_in_child_group
+    validator = make_validator(%w(n-depth-nested-group1))
+
     @ldap.stub :search, [@entry] do
-      validator = make_validator(%w(n-depth-nested-group1))
       assert validator.perform(@entry)
     end
   end
 
   def test_validates_user_in_grandchild_group
+    validator = make_validator(%w(n-depth-nested-group2))
+
     @ldap.stub :search, [@entry] do
-      validator = make_validator(%w(n-depth-nested-group2))
       assert validator.perform(@entry)
     end
   end
 
   def test_validates_user_in_great_grandchild_group
+    validator = make_validator(%w(n-depth-nested-group3))
+
     @ldap.stub :search, [@entry] do
-      validator = make_validator(%w(n-depth-nested-group3))
       assert validator.perform(@entry)
     end
   end
 
   def test_does_not_validate_user_not_in_group
+    validator = make_validator(%w(ghe-admins))
+
     @ldap.stub :search, [] do
-      validator = make_validator(%w(ghe-admins))
       refute validator.perform(@entry)
     end
   end
 
   def test_does_not_validate_user_not_in_any_group
     entry = @domain.user?('groupless-user1')
+    validator = make_validator(%w(all-users))
 
     @ldap.stub :search, [] do
-      validator = make_validator(%w(all-users))
       refute validator.perform(entry)
     end
   end
