From e219da1cb86aecd94e09188c930bef655a2b67f7 Mon Sep 17 00:00:00 2001 From: Matt Todd Date: Mon, 2 Feb 2015 14:30:48 -0800 Subject: [PATCH 1/2] Expand AD caps support to v60 This adds support for Windows Server 2008 and above, instead of only 2008 R2 and above. --- lib/github/ldap.rb | 4 ++-- test/ldap_test.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/github/ldap.rb b/lib/github/ldap.rb index ebdfddc..6384023 100644 --- a/lib/github/ldap.rb +++ b/lib/github/ldap.rb @@ -19,7 +19,7 @@ class Ldap # Internal: The capability required to use ActiveDirectory features. # See: http://msdn.microsoft.com/en-us/library/cc223359.aspx. - ACTIVE_DIRECTORY_V61_R2_OID = "1.2.840.113556.1.4.2080".freeze + ACTIVE_DIRECTORY_V60_OID = "1.2.840.113556.1.4.1935".freeze # Utility method to get the last operation result with a human friendly message. # @@ -313,7 +313,7 @@ def configure_member_search_strategy(strategy = nil) # # Returns true if the host is an ActiveDirectory server, false otherwise. def active_directory_capability? - capabilities[:supportedcapabilities].include?(ACTIVE_DIRECTORY_V61_R2_OID) + capabilities[:supportedcapabilities].include?(ACTIVE_DIRECTORY_V60_OID) end private :active_directory_capability? end diff --git a/test/ldap_test.rb b/test/ldap_test.rb index 48511d8..119c163 100644 --- a/test/ldap_test.rb +++ b/test/ldap_test.rb @@ -80,7 +80,7 @@ def test_search_strategy_defaults def test_search_strategy_detects_active_directory caps = Net::LDAP::Entry.new - caps[:supportedcapabilities] = [GitHub::Ldap::ACTIVE_DIRECTORY_V61_R2_OID] + caps[:supportedcapabilities] = [GitHub::Ldap::ACTIVE_DIRECTORY_V60_OID] @ldap.stub :capabilities, caps do @ldap.configure_search_strategy :detect From 5cfcb2f6457e34ebcd4f175aaf2d5913ee64bc31 Mon Sep 17 00:00:00 2001 From: Matt Todd Date: Mon, 2 Feb 2015 14:44:59 -0800 Subject: [PATCH 2/2] Bring back further to v51 for 2k3+ support --- lib/github/ldap.rb | 4 ++-- test/ldap_test.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/github/ldap.rb b/lib/github/ldap.rb index 6384023..0545247 100644 --- a/lib/github/ldap.rb +++ b/lib/github/ldap.rb @@ -19,7 +19,7 @@ class Ldap # Internal: The capability required to use ActiveDirectory features. # See: http://msdn.microsoft.com/en-us/library/cc223359.aspx. - ACTIVE_DIRECTORY_V60_OID = "1.2.840.113556.1.4.1935".freeze + ACTIVE_DIRECTORY_V51_OID = "1.2.840.113556.1.4.1670".freeze # Utility method to get the last operation result with a human friendly message. # @@ -313,7 +313,7 @@ def configure_member_search_strategy(strategy = nil) # # Returns true if the host is an ActiveDirectory server, false otherwise. def active_directory_capability? - capabilities[:supportedcapabilities].include?(ACTIVE_DIRECTORY_V60_OID) + capabilities[:supportedcapabilities].include?(ACTIVE_DIRECTORY_V51_OID) end private :active_directory_capability? end diff --git a/test/ldap_test.rb b/test/ldap_test.rb index 119c163..c7b24c4 100644 --- a/test/ldap_test.rb +++ b/test/ldap_test.rb @@ -80,7 +80,7 @@ def test_search_strategy_defaults def test_search_strategy_detects_active_directory caps = Net::LDAP::Entry.new - caps[:supportedcapabilities] = [GitHub::Ldap::ACTIVE_DIRECTORY_V60_OID] + caps[:supportedcapabilities] = [GitHub::Ldap::ACTIVE_DIRECTORY_V51_OID] @ldap.stub :capabilities, caps do @ldap.configure_search_strategy :detect pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy