rebase

ashwin-ant · ashwin-ant · commit 0f76168ce516 · 2025-04-08T07:45:04.000-07:00
diff --git a/pkg/github/pullrequests.go b/pkg/github/pullrequests.go
@@ -558,7 +558,7 @@ func AddPullRequestReviewComment(client *github.Client, t translations.Translati
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			pullNumber, err := requiredInt(request, "pull_number")
+			pullNumber, err := RequiredInt(request, "pull_number")
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
@@ -586,7 +586,7 @@ func AddPullRequestReviewComment(client *github.Client, t translations.Translati
 				comment.InReplyTo = github.Ptr(int64(replyToFloat))
 			} else {
 				// Handle subject_type parameter
-				subjectType, err := optionalParam[string](request, "subject_type")
+				subjectType, err := OptionalParam[string](request, "subject_type")
 				if err != nil {
 					return mcp.NewToolResultError(err.Error()), nil
 				}
@@ -684,11 +684,11 @@ func ReplyToPullRequestReviewComment(client *github.Client, t translations.Trans
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			pullNumber, err := requiredInt(request, "pull_number")
+			pullNumber, err := RequiredInt(request, "pull_number")
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			commentID, err := requiredInt(request, "comment_id")
+			commentID, err := RequiredInt(request, "comment_id")
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
diff --git a/pkg/github/pullrequests_test.go b/pkg/github/pullrequests_test.go
@@ -1728,7 +1728,7 @@ func Test_ReplyToPullRequestReviewComment(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			mockClient := github.NewClient(tc.mockedClient)
 
-			_, handler := replyToPullRequestReviewComment(mockClient, translations.NullTranslationHelper)
+			_, handler := ReplyToPullRequestReviewComment(mockClient, translations.NullTranslationHelper)
 
 			request := createMCPRequest(tc.requestArgs)
 

Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,7 @@ func AddPullRequestReviewComment(client *github.Client, t translations.Translati`
`558`	`558`	`if err != nil {`
`559`	`559`	`return mcp.NewToolResultError(err.Error()), nil`
`560`	`560`	`}`
`561`		`- pullNumber, err := requiredInt(request, "pull_number")`
	`561`	`+ pullNumber, err := RequiredInt(request, "pull_number")`
`562`	`562`	`if err != nil {`
`563`	`563`	`return mcp.NewToolResultError(err.Error()), nil`
`564`	`564`	`}`
`@@ -586,7 +586,7 @@ func AddPullRequestReviewComment(client *github.Client, t translations.Translati`
`586`	`586`	`comment.InReplyTo = github.Ptr(int64(replyToFloat))`
`587`	`587`	`} else {`
`588`	`588`	`// Handle subject_type parameter`
`589`		`- subjectType, err := optionalParam[string](request, "subject_type")`
	`589`	`+ subjectType, err := OptionalParam[string](request, "subject_type")`
`590`	`590`	`if err != nil {`
`591`	`591`	`return mcp.NewToolResultError(err.Error()), nil`
`592`	`592`	`}`
`@@ -684,11 +684,11 @@ func ReplyToPullRequestReviewComment(client *github.Client, t translations.Trans`
`684`	`684`	`if err != nil {`
`685`	`685`	`return mcp.NewToolResultError(err.Error()), nil`
`686`	`686`	`}`
`687`		`- pullNumber, err := requiredInt(request, "pull_number")`
	`687`	`+ pullNumber, err := RequiredInt(request, "pull_number")`
`688`	`688`	`if err != nil {`
`689`	`689`	`return mcp.NewToolResultError(err.Error()), nil`
`690`	`690`	`}`
`691`		`- commentID, err := requiredInt(request, "comment_id")`
	`691`	`+ commentID, err := RequiredInt(request, "comment_id")`
`692`	`692`	`if err != nil {`
`693`	`693`	`return mcp.NewToolResultError(err.Error()), nil`
`694`	`694`	`}`