Remove test that can panic

williammartin · williammartin · commit 11ea4e271dc1 · 2025-05-27T20:28:59.000+02:00
diff --git a/pkg/github/repository_resource.go b/pkg/github/repository_resource.go
@@ -201,6 +201,7 @@ func RepositoryResourceContentsHandler(getClient GetClientFn) func(ctx context.C
 			}
 		}
 
+		// This should be unreachable because GetContents should return an error if neither file nor directory content is found.
 		return nil, errors.New("no repository resource content found")
 	}
 }
diff --git a/pkg/github/repository_resource_test.go b/pkg/github/repository_resource_test.go
@@ -180,21 +180,6 @@ func Test_repositoryResourceContentsHandler(t *testing.T) {
 			},
 			expectedResult: expectedDirContent,
 		},
-		{
-			name: "no data",
-			mockedClient: mock.NewMockedHTTPClient(
-				mock.WithRequestMatch(
-					mock.GetReposContentsByOwnerByRepoByPath,
-				),
-			),
-			requestArgs: map[string]any{
-				"owner": []string{"owner"},
-				"repo":  []string{"repo"},
-				"path":  []string{"src"},
-			},
-			expectedResult: nil,
-			expectError:    "no repository resource content found",
-		},
 		{
 			name: "empty data",
 			mockedClient: mock.NewMockedHTTPClient(

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,7 @@ func RepositoryResourceContentsHandler(getClient GetClientFn) func(ctx context.C`
`201`	`201`	`}`
`202`	`202`	`}`
`203`	`203`
	`204`	`+ // This should be unreachable because GetContents should return an error if neither file nor directory content is found.`
`204`	`205`	`return nil, errors.New("no repository resource content found")`
`205`	`206`	`}`
`206`	`207`	`}`