Notifications Mark as done with number implementation (#270)

rfearing · SamMorrowDrums · commit 6776d1b79dfe · 2025-05-19T23:43:47.000+02:00
diff --git a/pkg/github/notifications.go b/pkg/github/notifications.go
@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"strconv"
 	"time"
 
 	"github.com/github/github-mcp-server/pkg/translations"
@@ -254,3 +255,46 @@ func GetNotificationThread(getClient GetClientFn, t translations.TranslationHelp
 			return mcp.NewToolResultText(string(r)), nil
 		}
 }
+
+// markNotificationDone creates a tool to mark a notification as done.
+func MarkNotificationDone(getclient GetClientFn, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) {
+	return mcp.NewTool("mark_notification_done",
+			mcp.WithDescription(t("TOOL_MARK_NOTIFICATION_DONE_DESCRIPTION", "Mark a notification as done")),
+			mcp.WithString("threadID",
+				mcp.Required(),
+				mcp.Description("The ID of the notification thread"),
+			),
+		),
+		func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) {
+			client, err := getclient(ctx)
+			if err != nil {
+				return nil, fmt.Errorf("failed to get GitHub client: %w", err)
+			}
+
+			threadIDStr, err := requiredParam[string](request, "threadID")
+			if err != nil {
+				return mcp.NewToolResultError(err.Error()), nil
+			}
+
+			threadID, err := strconv.ParseInt(threadIDStr, 10, 64)
+			if err != nil {
+				return mcp.NewToolResultError("Invalid threadID: must be a numeric value"), nil
+			}
+
+			resp, err := client.Activity.MarkThreadDone(ctx, threadID)
+			if err != nil {
+				return nil, fmt.Errorf("failed to mark notification as done: %w", err)
+			}
+			defer func() { _ = resp.Body.Close() }()
+
+			if resp.StatusCode != http.StatusResetContent && resp.StatusCode != http.StatusOK {
+				body, err := io.ReadAll(resp.Body)
+				if err != nil {
+					return nil, fmt.Errorf("failed to read response body: %w", err)
+				}
+				return mcp.NewToolResultError(fmt.Sprintf("failed to mark notification as done: %s", string(body))), nil
+			}
+
+			return mcp.NewToolResultText("Notification marked as done"), nil
+		}
+}
diff --git a/pkg/github/server.go b/pkg/github/server.go
@@ -94,6 +94,7 @@ func NewServer(version string, opts ...server.ServerOption) *server.MCPServer {
 	if !readOnly {
 		s.AddTool(MarkNotificationRead(getClient, t))
 		s.AddTool(MarkAllNotificationsRead(getClient, t))
+		s.AddTool(MarkNotificationDone(getClient, t))
 	}
 
 >>>>>>> dbdef79 (refactor: update notification functions to use GetClientFn  . Fix conflicts)

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ func NewServer(version string, opts ...server.ServerOption) *server.MCPServer {`
`94`	`94`	`if !readOnly {`
`95`	`95`	`s.AddTool(MarkNotificationRead(getClient, t))`
`96`	`96`	`s.AddTool(MarkAllNotificationsRead(getClient, t))`
	`97`	`+ s.AddTool(MarkNotificationDone(getClient, t))`
`97`	`98`	`}`
`98`	`99`
`99`	`100`	`>>>>>>> dbdef79 (refactor: update notification functions to use GetClientFn . Fix conflicts)`