Fix handling nil values for optional string array parameters, (#194)

A-Georgiou · web-flow · commit 86fbc8504fa5 · 2025-04-09T18:25:59.000+02:00
* Fix handling nil values for optional string array parameters,

nil values should be equivalent to an empty string, currently we return an error but Claude passes nil for optional values.

* lint fixes
diff --git a/pkg/github/issues_test.go b/pkg/github/issues_test.go
@@ -468,9 +468,10 @@ func Test_CreateIssue(t *testing.T) {
 				),
 			),
 			requestArgs: map[string]interface{}{
-				"owner": "owner",
-				"repo":  "repo",
-				"title": "Minimal Issue",
+				"owner":     "owner",
+				"repo":      "repo",
+				"title":     "Minimal Issue",
+				"assignees": nil, // Expect no failure with nil optional value.
 			},
 			expectError: false,
 			expectedIssue: &github.Issue{
diff --git a/pkg/github/server.go b/pkg/github/server.go
@@ -238,6 +238,8 @@ func OptionalStringArrayParam(r mcp.CallToolRequest, p string) ([]string, error)
 	}
 
 	switch v := r.Params.Arguments[p].(type) {
+	case nil:
+		return []string{}, nil
 	case []string:
 		return v, nil
 	case []any:

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,8 @@ func OptionalStringArrayParam(r mcp.CallToolRequest, p string) ([]string, error)`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`switch v := r.Params.Arguments[p].(type) {`
	`241`	`+ case nil:`
	`242`	`+ return []string{}, nil`
`241`	`243`	`case []string:`
`242`	`244`	`return v, nil`
`243`	`245`	`case []any:`