Skip to content

Tool tests could be a bit more strict in their assertions #83

New issue
New issue
Open
Open
Tool tests could be a bit more strict in their assertions#83
Labels
testing
@williammartin

Description

@williammartin
williammartin
opened on Apr 3, 2025

Description

On #82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we call the API with the expected values, only stubbing a response value:

github-mcp-server/pkg/github/issues_test.go

Lines 419 to 422 in bb56733

mock.WithRequestMatchHandler(
mock.PostReposIssuesByOwnerByRepo,
mockResponse(t, http.StatusCreated, mockIssue),
),

We should maybe look to tighten these tests up a bit, it would be very easy to break the tool implementations without knowing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    testing

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy