From a4d6d06eb1564f2ba607f35346da7d958f1e992b Mon Sep 17 00:00:00 2001 From: Jake Shorty Date: Fri, 11 Apr 2025 16:03:42 +0000 Subject: [PATCH] Prefer already-defined endpoint mock --- pkg/github/repositories_test.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pkg/github/repositories_test.go b/pkg/github/repositories_test.go index 2410a31da..5b8129fe7 100644 --- a/pkg/github/repositories_test.go +++ b/pkg/github/repositories_test.go @@ -517,11 +517,6 @@ func Test_GetCommit(t *testing.T) { }, }, } - // This one currently isn't defined in the mock package we're using. - var mockEndpointPattern = mock.EndpointPattern{ - Pattern: "/repos/{owner}/{repo}/commits/{sha}", - Method: "GET", - } tests := []struct { name string @@ -535,7 +530,7 @@ func Test_GetCommit(t *testing.T) { name: "successful commit fetch", mockedClient: mock.NewMockedHTTPClient( mock.WithRequestMatchHandler( - mockEndpointPattern, + mock.GetReposCommitsByOwnerByRepoByRef, mockResponse(t, http.StatusOK, mockCommit), ), ), @@ -551,7 +546,7 @@ func Test_GetCommit(t *testing.T) { name: "commit fetch fails", mockedClient: mock.NewMockedHTTPClient( mock.WithRequestMatchHandler( - mockEndpointPattern, + mock.GetReposCommitsByOwnerByRepoByRef, http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusNotFound) _, _ = w.Write([]byte(`{"message": "Not Found"}`)) pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy