Merge pull request #38 from github/td/lowercase-code-block-hotkey

keithamus · web-flow · commit 40b95c52efa5 · 2021-03-23T15:02:44.000Z
Change code block hotkey from E -&gt; e
diff --git a/src/index.ts b/src/index.ts
@@ -184,7 +184,7 @@ class MarkdownCodeButtonElement extends MarkdownButtonElement {
 
   connectedCallback() {
     super.connectedCallback()
-    this.setAttribute('hotkey', 'E')
+    this.setAttribute('hotkey', 'e')
   }
 }
 
diff --git a/test/test.js b/test/test.js
@@ -205,13 +205,6 @@ describe('markdown-toolbar-element', function () {
         pressHotkey('B') // capital `B` instead of lowercase `b`
         assert.equal('The |quick| brown fox jumps over the lazy dog', visualValue())
       })
-
-      it('does not codeblock selected text when using the lowercased hotkey', function () {
-        focus()
-        setVisualValue('The |quick| brown fox jumps over the lazy dog')
-        pressHotkey('e') // lowercase `e` instead of uppercase `E`
-        assert.equal('The |quick| brown fox jumps over the lazy dog', visualValue())
-      })
     })
 
     describe('bold', function () {
@@ -629,7 +622,7 @@ describe('markdown-toolbar-element', function () {
       it('surrounds a line with backticks via hotkey', function () {
         focus()
         setVisualValue("|puts 'Hello, world!'|")
-        pressHotkey('E')
+        pressHotkey('e')
         assert.equal("`|puts 'Hello, world!'|`", visualValue())
       })
 

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ class MarkdownCodeButtonElement extends MarkdownButtonElement {`
`184`	`184`
`185`	`185`	`connectedCallback() {`
`186`	`186`	`super.connectedCallback()`
`187`		`- this.setAttribute('hotkey', 'E')`
	`187`	`+ this.setAttribute('hotkey', 'e')`
`188`	`188`	`}`
`189`	`189`	`}`
`190`	`190`